From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: devicetree@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-tegra@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v5 0/6] Support DRM bridges on NVIDIA Tegra
Date: Sun, 24 May 2020 21:41:16 +0300 [thread overview]
Message-ID: <65a9c464-7031-586d-3b5e-d29ec01934ab@gmail.com> (raw)
In-Reply-To: <20200418170703.1583-1-digetx@gmail.com>
18.04.2020 20:06, Dmitry Osipenko пишет:
> Hello,
>
> This series adds initial support for the DRM bridges to NVIDIA Tegra DRM
> driver. This is required by newer device-trees where we model the LVDS
> encoder bridge properly.
>
> Changelog:
>
> v5: - Added new patches that make drm_of_find_panel_or_bridge() more usable
> if graph isn't defined in a device-tree:
>
> of_graph: add of_graph_get_local_port()
> drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence
>
> - Updated "Support DRM bridges" patch to use drm_of_find_panel_or_bridge()
> directly and added WARN_ON(output->panel || output->bridge) sanity-check.
>
> - Added new "Wrap directly-connected panel into DRM bridge" patch, as
> was suggested by Laurent Pinchart.
>
> v4: - Following review comments that were made by Laurent Pinchart to the v3,
> we now create and use the "bridge connector".
>
> v3: - Following recommendation from Sam Ravnborg, the new bridge attachment
> model is now being used, i.e. we ask bridge to *not* create a connector
> using the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag.
>
> - The bridge is now created only for the RGB (LVDS) output, and only
> when necessary. For now we don't need bridges for HDMI or DSI outputs.
>
> - I noticed that we're leaking OF node in the panel's error code path,
> this is fixed now by the new patch "Don't leak OF node on error".
>
> v2: - Added the new "rgb: Don't register connector if bridge is used"
> patch, which hides the unused connector provided by the Tegra DRM
> driver when bridge is used, since bridge provides its own connector
> to us.
>
> - Please notice that the first "Support DRM bridges" patch was previously
> sent out as a standalone v1 change.
>
> Dmitry Osipenko (6):
> of_graph: add of_graph_get_local_port()
> drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence
> drm/tegra: output: Don't leak OF node on error
> drm/tegra: output: Support DRM bridges
> drm/tegra: output: rgb: Support LVDS encoder bridge
> drm/tegra: output: rgb: Wrap directly-connected panel into DRM bridge
>
> drivers/gpu/drm/drm_of.c | 13 +++++-
> drivers/gpu/drm/tegra/drm.h | 2 +
> drivers/gpu/drm/tegra/output.c | 21 +++++++--
> drivers/gpu/drm/tegra/rgb.c | 85 +++++++++++++++++++++-------------
> drivers/of/property.c | 32 +++++++++----
> include/linux/of_graph.h | 7 +++
> 6 files changed, 114 insertions(+), 46 deletions(-)
>
Hello Thierry,
Do you you have any objections to this series?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-05-25 7:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 17:06 [PATCH v5 0/6] Support DRM bridges on NVIDIA Tegra Dmitry Osipenko
2020-04-18 17:06 ` [PATCH v5 1/6] of_graph: add of_graph_get_local_port() Dmitry Osipenko
2020-04-30 14:10 ` Rob Herring
2020-05-06 16:32 ` Sam Ravnborg
2020-05-11 20:27 ` Rob Herring
2020-04-18 17:06 ` [PATCH v5 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence Dmitry Osipenko
2020-05-06 16:41 ` Sam Ravnborg
2020-05-06 17:05 ` Dmitry Osipenko
2020-04-18 17:07 ` [PATCH v5 3/6] drm/tegra: output: Don't leak OF node on error Dmitry Osipenko
2020-05-06 16:42 ` Sam Ravnborg
2020-04-18 17:07 ` [PATCH v5 4/6] drm/tegra: output: Support DRM bridges Dmitry Osipenko
2020-05-06 16:43 ` Sam Ravnborg
2020-04-18 17:07 ` [PATCH v5 5/6] drm/tegra: output: rgb: Support LVDS encoder bridge Dmitry Osipenko
2020-05-06 16:45 ` Sam Ravnborg
2020-04-18 17:07 ` [PATCH v5 6/6] drm/tegra: output: rgb: Wrap directly-connected panel into DRM bridge Dmitry Osipenko
2020-04-25 17:02 ` Sam Ravnborg
2020-04-25 21:51 ` Dmitry Osipenko
2020-05-24 18:41 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a9c464-7031-586d-3b5e-d29ec01934ab@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).