From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB858C00144 for ; Tue, 26 Jul 2022 23:53:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17322B39A0; Tue, 26 Jul 2022 23:53:12 +0000 (UTC) Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C852B3938; Tue, 26 Jul 2022 23:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1658879590; x=1690415590; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=UKNaz1JC0WzSRSu1Y99lyIJ31lW1tdaK0bX7Ze/3lIk=; b=I46HA7PjJbwCivlLCfS2mlC7vjFjU9FlurNrryHRag2OHQGtBxCmUX7w hDvfrQTd2tsgL2Pkzeq7KnjdowVOb55/ddRyy5r2jsnpqUfvQIuRjaou6 d9fBmPTQetftD2he8Zd07JOv/iEEZHiqbL9/3tykW9BXT0kPGFfhfXlM5 4=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 26 Jul 2022 16:53:09 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 16:53:08 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 26 Jul 2022 16:53:08 -0700 Received: from [10.111.168.165] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 26 Jul 2022 16:53:04 -0700 Message-ID: <661fa514-cd37-e062-3294-c844b7f0b894@quicinc.com> Date: Tue, 26 Jul 2022 16:53:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [Freedreno] [PATCH] drm/msm/dsi: Don't set a load before disabling a regulator Content-Language: en-US To: Douglas Anderson , Rob Clark , Dmitry Baryshkov References: <20220725174810.1.If1f94fbbdb7c1d0fb3961de61483a851ad1971a7@changeid> From: Abhinav Kumar In-Reply-To: <20220725174810.1.If1f94fbbdb7c1d0fb3961de61483a851ad1971a7@changeid> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , Loic Poulain , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Jonathan Marek , David Airlie , Rajeev Nandan , Konrad Dybcio , AngeloGioacchino Del Regno , Vladimir Lypak , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , Vinod Koul , Mark Brown , linux-arm-msm@vger.kernel.org, Marijn Suijten , Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 7/25/2022 5:49 PM, Douglas Anderson wrote: > As of commit 5451781dadf8 ("regulator: core: Only count load for > enabled consumers"), a load isn't counted for a disabled > regulator. That means all the code in the DSI driver to specify and > set loads before disabling a regulator is not actually doing anything > useful. Let's remove it. > > It should be noted that all of the loads set that were being specified > were pointless noise anyway. The only use for this number is to pick > between low power and high power modes of regulators. Regulators > appear to do this changeover at loads on the order of 10000 uA. You > would a lot of clients of the same rail for that 100 uA number to I guess you meant "you would need a lot of clients" > count for anything. > > Note that now that we get rid of the setting of the load at disable > time, we can just set the load once when we first get the regulator > and then forget it. > > It should also be noted that the regulator functions > regulator_bulk_enable() and regulator_set_load() already print error > messages when they encounter problems so while moving things around we > get rid of some extra error prints. > > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/msm/dsi/dsi.h | 1 - > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 52 +++++++++---------- > drivers/gpu/drm/msm/dsi/dsi_host.c | 45 ++++------------ > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 46 ++++------------ > drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 4 +- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 6 +-- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c | 4 +- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 6 +-- > .../gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 2 +- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 6 +-- > 10 files changed, 60 insertions(+), 112 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h > index 580a1e6358bf..bb6a5bd05cb1 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.h > +++ b/drivers/gpu/drm/msm/dsi/dsi.h > @@ -37,7 +37,6 @@ enum msm_dsi_phy_usecase { > struct dsi_reg_entry { > char name[32]; > int enable_load; > - int disable_load; > }; > > struct dsi_reg_config { > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index 2c23324a2296..d24742ea32c6 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -14,9 +14,9 @@ static const struct msm_dsi_config apq8064_dsi_cfg = { > .reg_cfg = { > .num = 3, > .regs = { > - {"vdda", 100000, 100}, /* 1.2 V */ > - {"avdd", 10000, 100}, /* 3.0 V */ > - {"vddio", 100000, 100}, /* 1.8 V */ > + {"vdda", 100000}, /* 1.2 V */ > + {"avdd", 10000}, /* 3.0 V */ > + {"vddio", 100000}, /* 1.8 V */ > }, > }, > .bus_clk_names = dsi_v2_bus_clk_names, > @@ -34,9 +34,9 @@ static const struct msm_dsi_config msm8974_apq8084_dsi_cfg = { > .reg_cfg = { > .num = 3, > .regs = { > - {"vdd", 150000, 100}, /* 3.0 V */ > - {"vdda", 100000, 100}, /* 1.2 V */ > - {"vddio", 100000, 100}, /* 1.8 V */ > + {"vdd", 150000}, /* 3.0 V */ > + {"vdda", 100000}, /* 1.2 V */ > + {"vddio", 100000}, /* 1.8 V */ > }, > }, > .bus_clk_names = dsi_6g_bus_clk_names, > @@ -54,8 +54,8 @@ static const struct msm_dsi_config msm8916_dsi_cfg = { > .reg_cfg = { > .num = 2, > .regs = { > - {"vdda", 100000, 100}, /* 1.2 V */ > - {"vddio", 100000, 100}, /* 1.8 V */ > + {"vdda", 100000}, /* 1.2 V */ > + {"vddio", 100000}, /* 1.8 V */ > }, > }, > .bus_clk_names = dsi_8916_bus_clk_names, > @@ -73,8 +73,8 @@ static const struct msm_dsi_config msm8976_dsi_cfg = { > .reg_cfg = { > .num = 2, > .regs = { > - {"vdda", 100000, 100}, /* 1.2 V */ > - {"vddio", 100000, 100}, /* 1.8 V */ > + {"vdda", 100000}, /* 1.2 V */ > + {"vddio", 100000}, /* 1.8 V */ > }, > }, > .bus_clk_names = dsi_8976_bus_clk_names, > @@ -88,12 +88,12 @@ static const struct msm_dsi_config msm8994_dsi_cfg = { > .reg_cfg = { > .num = 6, > .regs = { > - {"vdda", 100000, 100}, /* 1.25 V */ > - {"vddio", 100000, 100}, /* 1.8 V */ > - {"vcca", 10000, 100}, /* 1.0 V */ > - {"vdd", 100000, 100}, /* 1.8 V */ > - {"lab_reg", -1, -1}, > - {"ibb_reg", -1, -1}, > + {"vdda", 100000}, /* 1.25 V */ > + {"vddio", 100000}, /* 1.8 V */ > + {"vcca", 10000}, /* 1.0 V */ > + {"vdd", 100000}, /* 1.8 V */ > + {"lab_reg", -1}, > + {"ibb_reg", -1}, > }, > }, > .bus_clk_names = dsi_6g_bus_clk_names, > @@ -111,9 +111,9 @@ static const struct msm_dsi_config msm8996_dsi_cfg = { > .reg_cfg = { > .num = 2, > .regs = { > - {"vdda", 18160, 1 }, /* 1.25 V */ > - {"vcca", 17000, 32 }, /* 0.925 V */ > - {"vddio", 100000, 100 },/* 1.8 V */ > + {"vdda", 18160}, /* 1.25 V */ > + {"vcca", 17000}, /* 0.925 V */ > + {"vddio", 100000},/* 1.8 V */ > }, > }, > .bus_clk_names = dsi_8996_bus_clk_names, > @@ -131,8 +131,8 @@ static const struct msm_dsi_config msm8998_dsi_cfg = { > .reg_cfg = { > .num = 2, > .regs = { > - {"vdd", 367000, 16 }, /* 0.9 V */ > - {"vdda", 62800, 2 }, /* 1.2 V */ > + {"vdd", 367000}, /* 0.9 V */ > + {"vdda", 62800}, /* 1.2 V */ > }, > }, > .bus_clk_names = dsi_msm8998_bus_clk_names, > @@ -150,7 +150,7 @@ static const struct msm_dsi_config sdm660_dsi_cfg = { > .reg_cfg = { > .num = 2, > .regs = { > - {"vdda", 12560, 4 }, /* 1.2 V */ > + {"vdda", 12560}, /* 1.2 V */ > }, > }, > .bus_clk_names = dsi_sdm660_bus_clk_names, > @@ -172,7 +172,7 @@ static const struct msm_dsi_config sdm845_dsi_cfg = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vdda", 21800, 4 }, /* 1.2 V */ > + {"vdda", 21800}, /* 1.2 V */ > }, > }, > .bus_clk_names = dsi_sdm845_bus_clk_names, > @@ -186,7 +186,7 @@ static const struct msm_dsi_config sc7180_dsi_cfg = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vdda", 21800, 4 }, /* 1.2 V */ > + {"vdda", 21800}, /* 1.2 V */ > }, > }, > .bus_clk_names = dsi_sc7180_bus_clk_names, > @@ -204,7 +204,7 @@ static const struct msm_dsi_config sc7280_dsi_cfg = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vdda", 8350, 0 }, /* 1.2 V */ > + {"vdda", 8350}, /* 1.2 V */ > }, > }, > .bus_clk_names = dsi_sc7280_bus_clk_names, > @@ -222,7 +222,7 @@ static const struct msm_dsi_config qcm2290_dsi_cfg = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vdda", 21800, 4 }, /* 1.2 V */ > + {"vdda", 21800}, /* 1.2 V */ > }, > }, > .bus_clk_names = dsi_qcm2290_bus_clk_names, > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index bab2634ebd11..c59e88d766de 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -259,15 +259,7 @@ static inline struct msm_dsi_host *to_msm_dsi_host(struct mipi_dsi_host *host) > static void dsi_host_regulator_disable(struct msm_dsi_host *msm_host) > { It seems like now we can drop this function dsi_host_regulator_disable() entirely and just call regulator_bulk_disable() ? > struct regulator_bulk_data *s = msm_host->supplies; > - const struct dsi_reg_entry *regs = msm_host->cfg_hnd->cfg->reg_cfg.regs; > int num = msm_host->cfg_hnd->cfg->reg_cfg.num; > - int i; > - > - DBG(""); > - for (i = num - 1; i >= 0; i--) > - if (regs[i].disable_load >= 0) > - regulator_set_load(s[i].consumer, > - regs[i].disable_load); > > regulator_bulk_disable(num, s); > } > @@ -275,35 +267,9 @@ static void dsi_host_regulator_disable(struct msm_dsi_host *msm_host) > static int dsi_host_regulator_enable(struct msm_dsi_host *msm_host) > { > struct regulator_bulk_data *s = msm_host->supplies; > - const struct dsi_reg_entry *regs = msm_host->cfg_hnd->cfg->reg_cfg.regs; > int num = msm_host->cfg_hnd->cfg->reg_cfg.num; > - int ret, i; > - > - DBG(""); > - for (i = 0; i < num; i++) { > - if (regs[i].enable_load >= 0) { > - ret = regulator_set_load(s[i].consumer, > - regs[i].enable_load); > - if (ret < 0) { > - pr_err("regulator %d set op mode failed, %d\n", > - i, ret); > - goto fail; > - } > - } > - } > - > - ret = regulator_bulk_enable(num, s); > - if (ret < 0) { > - pr_err("regulator enable failed, %d\n", ret); > - goto fail; > - } > > - return 0; > - > -fail: > - for (i--; i >= 0; i--) > - regulator_set_load(s[i].consumer, regs[i].disable_load); > - return ret; > + return regulator_bulk_enable(num, s); same here? We can just remove dsi_host_regulator_enable and just call regulator_bulk_enable() now? > } > > static int dsi_regulator_init(struct msm_dsi_host *msm_host) > @@ -323,6 +289,15 @@ static int dsi_regulator_init(struct msm_dsi_host *msm_host) > return ret; > } > > + for (i = 0; i < num; i++) { > + if (regs[i].enable_load >= 0) { > + ret = regulator_set_load(s[i].consumer, > + regs[i].enable_load); > + if (ret < 0) > + return ret; > + } > + } > + > return 0; > } > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index a39de3bdc7fa..330c0c4e7f9d 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -529,20 +529,22 @@ static int dsi_phy_regulator_init(struct msm_dsi_phy *phy) > return ret; > } > > + for (i = 0; i < num; i++) { > + if (regs[i].enable_load >= 0) { > + ret = regulator_set_load(s[i].consumer, > + regs[i].enable_load); > + if (ret < 0) > + return ret; > + } > + } > + > return 0; > } > > static void dsi_phy_regulator_disable(struct msm_dsi_phy *phy) > { > struct regulator_bulk_data *s = phy->supplies; > - const struct dsi_reg_entry *regs = phy->cfg->reg_cfg.regs; > int num = phy->cfg->reg_cfg.num; > - int i; > - > - DBG(""); > - for (i = num - 1; i >= 0; i--) > - if (regs[i].disable_load >= 0) > - regulator_set_load(s[i].consumer, regs[i].disable_load); > > regulator_bulk_disable(num, s); > } > @@ -550,37 +552,9 @@ static void dsi_phy_regulator_disable(struct msm_dsi_phy *phy) > static int dsi_phy_regulator_enable(struct msm_dsi_phy *phy) > { > struct regulator_bulk_data *s = phy->supplies; > - const struct dsi_reg_entry *regs = phy->cfg->reg_cfg.regs; > - struct device *dev = &phy->pdev->dev; > int num = phy->cfg->reg_cfg.num; > - int ret, i; > > - DBG(""); > - for (i = 0; i < num; i++) { > - if (regs[i].enable_load >= 0) { > - ret = regulator_set_load(s[i].consumer, > - regs[i].enable_load); > - if (ret < 0) { > - DRM_DEV_ERROR(dev, > - "regulator %d set op mode failed, %d\n", > - i, ret); > - goto fail; > - } > - } > - } > - > - ret = regulator_bulk_enable(num, s); > - if (ret < 0) { > - DRM_DEV_ERROR(dev, "regulator enable failed, %d\n", ret); > - goto fail; > - } > - > - return 0; > - > -fail: > - for (i--; i >= 0; i--) > - regulator_set_load(s[i].consumer, regs[i].disable_load); > - return ret; > + return regulator_bulk_enable(num, s); > } > > static int dsi_phy_enable_resource(struct msm_dsi_phy *phy) > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c > index 08b015ea1b1e..6a10a1448051 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c > @@ -1033,7 +1033,7 @@ const struct msm_dsi_phy_cfg dsi_phy_10nm_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vdds", 36000, 32}, > + {"vdds", 36000}, > }, > }, > .ops = { > @@ -1055,7 +1055,7 @@ const struct msm_dsi_phy_cfg dsi_phy_10nm_8998_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vdds", 36000, 32}, > + {"vdds", 36000}, > }, > }, > .ops = { > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > index 8199c53567f4..0f3d4c56c333 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > @@ -1029,7 +1029,7 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vcca", 17000, 32}, > + {"vcca", 17000}, > }, > }, > .ops = { > @@ -1050,7 +1050,7 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_660_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vcca", 73400, 32}, > + {"vcca", 73400}, > }, > }, > .ops = { > @@ -1071,7 +1071,7 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_8953_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vcca", 17000, 32}, > + {"vcca", 17000}, > }, > }, > .ops = { > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c > index ee7c418a1c29..b7c621d94981 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c > @@ -134,8 +134,8 @@ const struct msm_dsi_phy_cfg dsi_phy_20nm_cfgs = { > .reg_cfg = { > .num = 2, > .regs = { > - {"vddio", 100000, 100}, /* 1.8 V */ > - {"vcca", 10000, 100}, /* 1.0 V */ > + {"vddio", 100000}, /* 1.8 V */ > + {"vcca", 10000}, /* 1.0 V */ > }, > }, > .ops = { > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c > index 48eab80b548e..6beba387640d 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c > @@ -774,7 +774,7 @@ const struct msm_dsi_phy_cfg dsi_phy_28nm_hpm_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vddio", 100000, 100}, > + {"vddio", 100000}, > }, > }, > .ops = { > @@ -795,7 +795,7 @@ const struct msm_dsi_phy_cfg dsi_phy_28nm_hpm_famb_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vddio", 100000, 100}, > + {"vddio", 100000}, > }, > }, > .ops = { > @@ -816,7 +816,7 @@ const struct msm_dsi_phy_cfg dsi_phy_28nm_lp_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vddio", 100000, 100}, /* 1.8 V */ > + {"vddio", 100000}, /* 1.8 V */ > }, > }, > .ops = { > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c > index fc56cdcc9ad6..2e942b10fffa 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c > @@ -653,7 +653,7 @@ const struct msm_dsi_phy_cfg dsi_phy_28nm_8960_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vddio", 100000, 100}, /* 1.8 V */ > + {"vddio", 100000}, /* 1.8 V */ > }, > }, > .ops = { > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c > index 66ed1919a1db..9c7c49ce1200 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c > @@ -1041,7 +1041,7 @@ const struct msm_dsi_phy_cfg dsi_phy_7nm_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vdds", 36000, 32}, > + {"vdds", 36000}, > }, > }, > .ops = { > @@ -1068,7 +1068,7 @@ const struct msm_dsi_phy_cfg dsi_phy_7nm_8150_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vdds", 36000, 32}, > + {"vdds", 36000}, > }, > }, > .ops = { > @@ -1090,7 +1090,7 @@ const struct msm_dsi_phy_cfg dsi_phy_7nm_7280_cfgs = { > .reg_cfg = { > .num = 1, > .regs = { > - {"vdds", 37550, 0}, > + {"vdds", 37550}, > }, > }, > .ops = {