From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2DF9C433EF for ; Tue, 28 Sep 2021 17:23:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87E306124A for ; Tue, 28 Sep 2021 17:23:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 87E306124A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD9DE6E8F9; Tue, 28 Sep 2021 17:23:05 +0000 (UTC) Received: from so254-9.mailgun.net (so254-9.mailgun.net [198.61.254.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7BDF6E8F9 for ; Tue, 28 Sep 2021 17:22:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632849784; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=mb/o+TU/jtzYpiRKctEI+EzDEsfd4AjUR8iTNCtSlZo=; b=NXU8BmSLWeoi9UuC6UF6HMRRiWKlu/GQMSX894mZ4qeb2AbEffS4XZZWosDt1thCXlIACG4I zkBWLW4iq7S8ajcmZwuW8jmNNgqG4pbBkMyo7diG3MPqe1FaxAAe4QrKByvAKbihj9tj/66c ceHdRvKy4rdZ3Q6xyyYVeTourMg= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 61534f64a5a9bab6e8c9faa8 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 28 Sep 2021 17:22:44 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6073CC44BC2; Tue, 28 Sep 2021 17:22:43 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id B7904C008EF; Tue, 28 Sep 2021 17:22:41 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Sep 2021 10:22:41 -0700 From: khsieh@codeaurora.org To: Bjorn Andersson Cc: Stephen Boyd , Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Kalyan Thota , Rob Clark , Sean Paul , Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers In-Reply-To: References: <20210825234233.1721068-1-bjorn.andersson@linaro.org> <20210825234233.1721068-4-bjorn.andersson@linaro.org> Message-ID: <66f0f29e449b02e30678ed2e3487c7f2@codeaurora.org> X-Sender: khsieh@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-08-27 10:14, Bjorn Andersson wrote: > On Fri 27 Aug 00:20 CDT 2021, Stephen Boyd wrote: > >> Quoting Bjorn Andersson (2021-08-25 16:42:31) >> > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> > index 2c7de43f655a..4a6132c18e57 100644 >> > --- a/drivers/gpu/drm/msm/dp/dp_display.c >> > +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> > @@ -78,6 +78,8 @@ struct dp_display_private { >> > char *name; >> > int irq; >> > >> > + int id; >> > + >> > /* state variables */ >> > bool core_initialized; >> > bool hpd_irq_on; >> > @@ -115,8 +117,19 @@ struct dp_display_private { >> > struct dp_audio *audio; >> > }; >> > >> > + >> > +struct msm_dp_config { >> > + phys_addr_t io_start[3]; >> >> Can this be made into another struct, like msm_dp_desc, that also >> indicates what type of DP connector it is, i.e. eDP vs DP? That would >> help me understand in modetest and /sys/class/drm what sort of >> connector >> is probing. dp_drm_connector_init() would need to pass the type of >> connector appropriately. Right now, eDP connectors still show up as DP >> instead of eDP in sysfs. >> > > I like it, will spin a v3 with this. > > Regards, > Bjorn Hi Bjorn, Have you spin off V3 yet? When you expect your patches related to DP be up streamed? Thanks, kuogee > >> > + size_t num_dp; >> > +}; >> > + >> > +static const struct msm_dp_config sc7180_dp_cfg = { >> > + .io_start = { 0x0ae90000 }, >> > + .num_dp = 1, >> > +}; >> > + >> > static const struct of_device_id dp_dt_match[] = { >> > - {.compatible = "qcom,sc7180-dp"}, >> > + { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg }, >> > {} >> > }; >> >