From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "Shuijing Li (李水静)" <Shuijing.Li@mediatek.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c
Date: Thu, 7 Sep 2023 06:08:46 +0000 [thread overview]
Message-ID: <67813ea6e688036d68c10fa979562b6aab80bda9.camel@mediatek.com> (raw)
In-Reply-To: <20230616073659.26536-3-shuijing.li@mediatek.com>
[-- Attachment #1: Type: text/html, Size: 4349 bytes --]
[-- Attachment #2: Type: text/plain, Size: 2219 bytes --]
Hi, Shuijing:
On Fri, 2023-06-16 at 15:36 +0800, Shuijing Li wrote:
> Add the compatible because there are different definitions for cmdq
> register bit control in mt8188.
>
> Signed-off-by: Shuijing Li <shuijing.li@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
> drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 6dcb4ba2466c..0070894d0148 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -764,6 +764,8 @@ static const struct of_device_id
> mtk_ddp_comp_dt_ids[] = {
> .data = (void *)MTK_DSI },
> { .compatible = "mediatek,mt8186-dsi",
> .data = (void *)MTK_DSI },
> + { .compatible = "mediatek,mt8188-dsi",
> + .data = (void *)MTK_DSI },
> { }
> };
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 7d5250351193..500a3054282d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data
> mt8186_dsi_driver_data = {
> .has_size_ctl = true,
> };
>
> +static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
> + .reg_cmdq_off = 0xd00,
> + .has_shadow_ctl = true,
> + .has_size_ctl = true,
> +};
> +
> static const struct of_device_id mtk_dsi_of_match[] = {
> { .compatible = "mediatek,mt2701-dsi",
> .data = &mt2701_dsi_driver_data },
> @@ -1217,6 +1223,8 @@ static const struct of_device_id
> mtk_dsi_of_match[] = {
> .data = &mt8183_dsi_driver_data },
> { .compatible = "mediatek,mt8186-dsi",
> .data = &mt8186_dsi_driver_data },
> + { .compatible = "mediatek,mt8188-dsi",
> + .data = &mt8188_dsi_driver_data },
mt8188_dsi_driver_data is identical to mt8186_dsi_driver_data, so use
mt8186_dsi_driver_data and drop mt8188_dsi_driver_data.
Regards,
CK
> { },
> };
> MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
next prev parent reply other threads:[~2023-09-07 6:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 7:36 [PATCH v2,0/3] Add mt8188 compatiable for DSI cmd packet control Shuijing Li
2023-06-16 7:36 ` [PATCH v2, 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188 Shuijing Li
2023-06-16 7:36 ` [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c Shuijing Li
2023-09-07 6:08 ` CK Hu (胡俊光) [this message]
2023-09-07 6:12 ` CK Hu (胡俊光)
2023-06-16 7:36 ` [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code Shuijing Li
2023-06-19 15:20 ` Matthias Brugger
2023-08-14 8:47 ` Shuijing Li (李水静)
2023-09-07 6:21 ` CK Hu (胡俊光)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67813ea6e688036d68c10fa979562b6aab80bda9.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Shuijing.Li@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).