Re: [PATCH 0/2] drm: Add component_match_add_of and convert users of drm_of_component_match_add

From: Sean Anderson <sean.anderson@seco.com>
To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org
Cc: alsa-devel@alsa-project.org,
	Xinliang Liu <xinliang.liu@linaro.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	linux-kernel@vger.kernel.org,
	Paul Cercueil <paul@crapouillou.net>,
	John Stultz <jstultz@google.com>,
	Mihail Atanassov <mihail.atanassov@arm.com>,
	Will Deacon <will@kernel.org>,
	Samuel Holland <samuel@sholland.org>,
	Joerg Roedel <joro@8bytes.org>, Takashi Iwai <tiwai@suse.com>,
	Russell King <linux@armlinux.org.uk>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Mali DP Maintainers <malidp@foss.arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	Alain Volmat <alain.volmat@foss.st.com>,
	Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	linux-sunxi@lists.linux.dev,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Chen Feng <puck.chen@hisilicon.com>,
	freedreno@lists.freedesktop.org,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	etnaviv@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Sean Paul <sean@poorly.run>,
	Yong Wu <yong.wu@mediatek.com>,
	linux-mips@vger.kernel.org, Tomi Valkeinen <tomba@kernel.org>,
	iommu@lists.linux.dev, Robin Murphy <robin.murphy@arm.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Tian Tao <tiantao6@hisilicon.com>, Jyri Sarha <jyri.sarha@iki.fi>
Subject: Re: [PATCH 0/2] drm: Add component_match_add_of and convert users of drm_of_component_match_add
Date: Fri, 16 Dec 2022 12:08:51 -0500	[thread overview]
Message-ID: <68562aca-5256-9e4b-bcd5-983e43408a7d@seco.com> (raw)
In-Reply-To: <20221103182222.2247724-1-sean.anderson@seco.com>

On 11/3/22 14:22, Sean Anderson wrote:
> This series adds a new function component_match_add_of to simplify the
> common case of calling component_match_add_release with
> component_release_of and component_compare_of. There is already
> drm_of_component_match_add, which allows for a custom compare function.
> However, all existing users just use component_compare_of (or an
> equivalent).
> 
> I can split the second commit up if that is easier to review.
> 
> 
> Sean Anderson (2):
>   component: Add helper for device nodes
>   drm: Convert users of drm_of_component_match_add to
>     component_match_add_of
> 
>  .../gpu/drm/arm/display/komeda/komeda_drv.c   |  6 ++--
>  drivers/gpu/drm/arm/hdlcd_drv.c               |  9 +-----
>  drivers/gpu/drm/arm/malidp_drv.c              | 11 +------
>  drivers/gpu/drm/armada/armada_drv.c           | 10 ++++---
>  drivers/gpu/drm/drm_of.c                      | 29 +++----------------
>  drivers/gpu/drm/etnaviv/etnaviv_drv.c         |  4 +--
>  .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c   |  3 +-
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c     |  3 +-
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  4 +--
>  drivers/gpu/drm/msm/msm_drv.c                 | 14 ++++-----
>  drivers/gpu/drm/sti/sti_drv.c                 |  3 +-
>  drivers/gpu/drm/sun4i/sun4i_drv.c             |  3 +-
>  drivers/gpu/drm/tilcdc/tilcdc_external.c      | 10 ++-----
>  drivers/iommu/mtk_iommu.c                     |  3 +-
>  drivers/iommu/mtk_iommu_v1.c                  |  3 +-
>  include/drm/drm_of.h                          | 12 --------
>  include/linux/component.h                     |  9 ++++++
>  sound/soc/codecs/wcd938x.c                    |  6 ++--
>  18 files changed, 46 insertions(+), 96 deletions(-)
> 

ping?

Should I send a v2 broken up like Mark suggested?

--Sean