From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACCF8ECAAD3 for ; Sun, 11 Sep 2022 18:37:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AB6C10E0DE; Sun, 11 Sep 2022 18:36:58 +0000 (UTC) Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EE8310E0DC for ; Sun, 11 Sep 2022 18:36:55 +0000 (UTC) Received: by mail-lj1-x229.google.com with SMTP id v6so8201258ljj.0 for ; Sun, 11 Sep 2022 11:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=HEGKAKK1OqGgF3tIA2jjvvuMVVe0d6JEaemGS/L/y8U=; b=WpXgzNWoYrIbGwvpKV+qZ25JAOEjKIESKDLJbLOuTtr4m89vwB70GUvxDiUUjPeagy A7tNxBtZFDJYIBgbd1u99stOnpe6EVzSt5O1/nsxMk8CWJSEno7bVS/zhTXu1QVY8U7U xXaVWl2jPxEY5UPn1sz+A9J/U1aFGADL/sy3xpYq3STq3/Fv+lka3sxzWaw4rh8yczU7 9fNiUsA23wx+HOELxYXwncUEtR5y9cfuVHbhC8Q8kTyUIwsUMVvV5NkjSzfp1uqPKqdu TV4EikYi6fXdySveGfE4Aqx9NlkepayOuyytK9NBGTN6eAeldOfMNvShRZwLEdy1JY56 myow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=HEGKAKK1OqGgF3tIA2jjvvuMVVe0d6JEaemGS/L/y8U=; b=xCEyVyK1msAICYkwCB4A5yJfCtqZfVTiC4Fn9SIJ5wA4xj9u809kpd0OpBSry3Y+mq TehGrTYObsIbj42a6oX7hdI0P0tW9NvcBxnWylVmFRa6GOr4Zg72FqKjmZYCwLq7h/O5 oBaKuHMaSs3FAlgGVYbq42cIJP3OtNqCXV8Xo7R4EHxhHURhaFEiqylc9Loaz6jkYWGw C+5t9yA8e18RB+Co0Ky6a5ZfyZIuRATBJeLRQFQYxcyOR6JVPmmflFspwypz/Z+gBtpB 52qCpiAj/2oCHHnk5nh+w9AoWB4EsDbhA7Ym7DUWvx80l/DkvY/qHbMvEh3tJLJLvXzS pjEg== X-Gm-Message-State: ACgBeo0hcpgbx32fPENcd6YC7FM+p1GWEpbODRiC5y1nMytx1bqqTNSJ 0S8FPllJGa3Oii0a8inyMdDJEw== X-Google-Smtp-Source: AA6agR414d7OgEiTCUavbnSUu/a+GLfdR22e6CqyXsFSb3o+Ap4GP8nLHn2EH/xpoe0hx5wc+gaTdw== X-Received: by 2002:a05:651c:b08:b0:26b:dbae:1d8b with SMTP id b8-20020a05651c0b0800b0026bdbae1d8bmr5145910ljr.85.1662921413069; Sun, 11 Sep 2022 11:36:53 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id p3-20020a05651238c300b00498f36bce07sm686441lft.214.2022.09.11.11.36.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Sep 2022 11:36:52 -0700 (PDT) Message-ID: <6e3bca5a-8b01-af12-ae69-b0044a8790f6@linaro.org> Date: Sun, 11 Sep 2022 20:36:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Content-Language: en-US From: Krzysztof Kozlowski To: Dmitry Baryshkov References: <20220901102312.2005553-1-dmitry.baryshkov@linaro.org> <20220901102312.2005553-2-dmitry.baryshkov@linaro.org> <3e525135-d205-eddc-ff2d-98c8321386e3@linaro.org> <20220908193705.GA3002673-robh@kernel.org> <1ebe64a3-fab9-1dd7-517a-01001a176d9f@linaro.org> <2204eab4-b22d-8ee7-4595-49139cb387a8@linaro.org> <272413e3-73d4-8e0d-7b5d-93007e419f76@linaro.org> In-Reply-To: <272413e3-73d4-8e0d-7b5d-93007e419f76@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Loic Poulain , devicetree@vger.kernel.org, David Airlie , linux-arm-msm , Bjorn Andersson , Konrad Dybcio , Abhinav Kumar , dri-devel , Stephen Boyd , Andy Gross , Krzysztof Kozlowski , freedreno , Sean Paul , AngeloGioacchino Del Regno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 11/09/2022 20:32, Krzysztof Kozlowski wrote: > On 11/09/2022 19:45, Dmitry Baryshkov wrote: >> On Sun, 11 Sept 2022 at 16:57, Krzysztof Kozlowski >> wrote: >>> >>> On 11/09/2022 15:45, Dmitry Baryshkov wrote: >>>> On Sun, 11 Sept 2022 at 14:27, Krzysztof Kozlowski >>>> wrote: >>>>> >>>>> On 10/09/2022 14:54, Dmitry Baryshkov wrote: >>>>>>> >>>>>>> However I think there is no such problem, as Dmitry said, that ref >>>>>>> changes anything. There will be always failure - either from parent >>>>>>> schema (using $ref) or from device child schema (the one which actually >>>>>>> misses the property). >>>>>> >>>>>> Initially I stumbled upon this issue with the dsi and dsi_phy nodes >>>>>> for msm8996 devices. If I have $ref here, dsi1/dsi1_phy nodes will >>>>>> emit warnings regarding the missing -supply properties despite nodes >>>>>> being disabled. If I use `compatible' here, the schema checks pass. >>>>>> Thus I'd prefer to leave `compatible' here. Not to mention that it >>>>>> also allows specifying a tighter binding than just using the $ref. >>>>> >>>>> I don't think we understood each other. I claim that error will be there >>>>> anyway, just from different schema. So your change fixes nothing in >>>>> total schema check... >>>> >>>> If the node is disabled, there will be no different schema check. >>> >>> As I wrote before, there was. >> >> The following results were captured with the following command, with >> most of the DSI and MDSS schema files fixed, using the following >> command: >> $ PATH=~/.local/bin/:$PATH make -C ../build-64/ ARCH=arm64 >> qcom/sda660-inforce-ifc6560.dtb CHECK_DTBS=y >> DT_SCHEMA_FILES=display/msm >> >> As you can see from the example below, when using 'compatible' I'm >> getting warnings just for the gpu@5000000 node, while using $ref I >> also got warnings for the dsi-phy@c996400 node (disabled in the DT >> file). >> For your reference the tree in question is uploaded to the: >> https://git.linaro.org/people/dmitry.baryshkov/kernel.git msm-mdss-yaml > > I did not say anything about msm-mdss. I said you will get errors from > child schema anyway. > > From schema: > /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb: > dsi@c994000: clock-names: ['mdp_core', 'byte', 'byte_intf', 'mnoc', > 'iface', 'bus', 'core_mmss', 'pixel', 'core'] is too long > > From schema: > /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb: > dsi@c994000: 'vdda-supply' does not match any of the regexes: > 'pinctrl-[0-9]+' > > > > If your child schema fails, the referencing schema fails as well... Although now with DSI-PHY I cannot reproduce it and I am pretty sure I reproduced it with DPU controllers after modifying the DTS to lack a property... Hmmm Best regards, Krzysztof