From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] fbdev: potential information leak in do_fb_ioctl() Date: Thu, 31 Oct 2019 11:16:39 -0700 Message-ID: <734ef2833e4e4e7bded92e9d964bc2415aadf3c4.camel@perches.com> References: <20191029182320.GA17569@mwanda> <87zhhjjryk.fsf@x220.int.ebiederm.org> <20191030074321.GD2656@xps-13> <87r22ujaqq.fsf@x220.int.ebiederm.org> <20191030201201.GA3209@xps-13> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191030201201.GA3209@xps-13> Sender: linux-kernel-owner@vger.kernel.org To: Andrea Righi , "Eric W. Biederman" Cc: Dan Carpenter , Bartlomiej Zolnierkiewicz , Daniel Vetter , Sam Ravnborg , Maarten Lankhorst , Peter Rosin , Gerd Hoffmann , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, security@kernel.org, Kees Cook , Julia Lawall List-Id: dri-devel@lists.freedesktop.org On Wed, 2019-10-30 at 21:12 +0100, Andrea Righi wrote: > Then memset() + memcpy() is probably the best option, > since copying all those fields one by one looks quite ugly to me... A memset of an automatic before a memcpy to the same automatic is unnecessary. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29593CA9ECB for ; Thu, 31 Oct 2019 18:16:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 077C6208E3 for ; Thu, 31 Oct 2019 18:16:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 077C6208E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F4FB6E0C8; Thu, 31 Oct 2019 18:16:53 +0000 (UTC) Received: from smtprelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78CAD6E0C8 for ; Thu, 31 Oct 2019 18:16:52 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 354811822563C; Thu, 31 Oct 2019 18:16:51 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sea16_75aca35dfcc57 X-Filterd-Recvd-Size: 1678 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Thu, 31 Oct 2019 18:16:48 +0000 (UTC) Message-ID: <734ef2833e4e4e7bded92e9d964bc2415aadf3c4.camel@perches.com> Subject: Re: [PATCH] fbdev: potential information leak in do_fb_ioctl() From: Joe Perches To: Andrea Righi , "Eric W. Biederman" Date: Thu, 31 Oct 2019 11:16:39 -0700 In-Reply-To: <20191030201201.GA3209@xps-13> References: <20191029182320.GA17569@mwanda> <87zhhjjryk.fsf@x220.int.ebiederm.org> <20191030074321.GD2656@xps-13> <87r22ujaqq.fsf@x220.int.ebiederm.org> <20191030201201.GA3209@xps-13> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, security@kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , kernel-janitors@vger.kernel.org, Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Julia Lawall , Gerd Hoffmann , Sam Ravnborg , Peter Rosin , Dan Carpenter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191031181639.tUzwjIJEuxNSbC7bITZi6LAmppeQStG-OVe-1DFqb3w@z> T24gV2VkLCAyMDE5LTEwLTMwIGF0IDIxOjEyICswMTAwLCBBbmRyZWEgUmlnaGkgd3JvdGU6Cj4g VGhlbiBtZW1zZXQoKSArIG1lbWNweSgpIGlzIHByb2JhYmx5IHRoZSBiZXN0IG9wdGlvbiwKPiBz aW5jZSBjb3B5aW5nIGFsbCB0aG9zZSBmaWVsZHMgb25lIGJ5IG9uZSBsb29rcyBxdWl0ZSB1Z2x5 IHRvIG1lLi4uCgpBIG1lbXNldCBvZiBhbiBhdXRvbWF0aWMgYmVmb3JlIGEgbWVtY3B5IHRvIHRo ZSBzYW1lCmF1dG9tYXRpYyBpcyB1bm5lY2Vzc2FyeS4KCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWw=