From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Daniel Gomez <dagmcr@gmail.com>,
daniel@ffwll.ch, airlied@linux.ie,
laurent.pinchart@ideasonboard.com
Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: rcar-du: Fix build error
Date: Fri, 22 May 2020 10:43:39 +0100 [thread overview]
Message-ID: <73d98905-930d-3549-1a85-293f4d213716@ideasonboard.com> (raw)
In-Reply-To: <20200518201646.48312-1-dagmcr@gmail.com>
Hi Daniel,
On 18/05/2020 21:16, Daniel Gomez wrote:
> Select DRM_KMS_HELPER dependency.
>
> Build error when DRM_KMS_HELPER is not selected:
>
> drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd48): undefined reference to `drm_atomic_helper_bridge_duplicate_state'
> drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd50): undefined reference to `drm_atomic_helper_bridge_destroy_state'
> drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd70): undefined reference to `drm_atomic_helper_bridge_reset'
> drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xdc8): undefined reference to `drm_atomic_helper_connector_reset'
> drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xde0): undefined reference to `drm_helper_probe_single_connector_modes'
> drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xe08): undefined reference to `drm_atomic_helper_connector_duplicate_state'
> drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xe10): undefined reference to `drm_atomic_helper_connector_destroy_state'
>
Looking at the files in rcar_du that utilise drm_atomic_helpers...
git grep -l drm_atomic_helper_ drivers/gpu/drm/rcar-du/
drivers/gpu/drm/rcar-du/rcar_du_crtc.c
drivers/gpu/drm/rcar-du/rcar_du_kms.c
drivers/gpu/drm/rcar-du/rcar_du_plane.c
drivers/gpu/drm/rcar-du/rcar_du_vsp.c
drivers/gpu/drm/rcar-du/rcar_du_writeback.c
drivers/gpu/drm/rcar-du/rcar_lvds.c
of those, these are configurable:
rcar_du_vsp.c # DRM_RCAR_VSP
rcar_du_writeback.c # DRM_RCAR_WRITEBACK
rcar_lvds.c # DRM_RCAR_LVDS
But VSP and WRITEBACK are already implicitly dependant upon DRM_RCAR_DU
because they get built into the DU module.
So indeed, only the RCAR_LVDS is a separate module, using those helpers,
so I think a select is a reasonable fix.
I would also ask whether DRM_RCAR_LVDS should depend upon DRM_RCAR_DU
though as well.
There is no linkage requirement, as it's a standalone bridge driver from
what I can see, but I don't think it serves much purpose without the DU?
Anyway, even if it's just for compile testing maybe, the select here
should be fine.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> ---
> drivers/gpu/drm/rcar-du/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> index 0919f1f159a4..f65d1489dc50 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -31,6 +31,7 @@ config DRM_RCAR_DW_HDMI
> config DRM_RCAR_LVDS
> tristate "R-Car DU LVDS Encoder Support"
> depends on DRM && DRM_BRIDGE && OF
> + select DRM_KMS_HELPER
> select DRM_PANEL
> select OF_FLATTREE
> select OF_OVERLAY
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-22 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 20:16 [PATCH] drm: rcar-du: Fix build error Daniel Gomez
2020-05-19 20:22 ` Emil Velikov
2020-05-22 9:43 ` Kieran Bingham [this message]
2020-05-22 10:36 ` Daniel G
2020-05-22 20:23 ` Laurent Pinchart
2020-05-23 9:38 ` Daniel G
-- strict thread matches above, loose matches on Subject: below --
2019-01-18 17:21 Nathan Chancellor
2019-01-22 20:33 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d98905-930d-3549-1a85-293f4d213716@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=dagmcr@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).