From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CAACEB64D9 for ; Sat, 17 Jun 2023 16:34:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4D5210E07C; Sat, 17 Jun 2023 16:34:39 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE5F310E07C for ; Sat, 17 Jun 2023 16:34:37 +0000 (UTC) Received: from i53875b22.versanet.de ([83.135.91.34] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qAYsg-0007Kt-6E; Sat, 17 Jun 2023 18:34:30 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Maximilian Weigand , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krzysztof Kozlowski Subject: Re: [PATCH 2/3] dt-bindings: backlight: lm3630a: add entries to control boost frequency Date: Sat, 17 Jun 2023 18:34:28 +0200 Message-ID: <7491264.lOV4Wx5bFT@diego> In-Reply-To: <17576d81-a342-0b77-367a-eb9f2b97b734@linaro.org> References: <20230602-lm3630a_boost_frequency-v1-0-076472036d1a@mweigand.net> <20230602-lm3630a_boost_frequency-v1-2-076472036d1a@mweigand.net> <17576d81-a342-0b77-367a-eb9f2b97b734@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Maximilian Weigand , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Samstag, 17. Juni 2023, 12:12:17 CEST schrieb Krzysztof Kozlowski: > On 14/06/2023 21:08, Maximilian Weigand wrote: > > From: Maximilian Weigand > > > > Add 'ti,boost_use_1mhz' to switch between 500 kHz and 1 MHz boost > > converter switching frequency, and add 'ti,boost_frequency_shift' to > > activate a frequency shift to 560 kHz or 1.12 MHz, respectively. > > > > Signed-off-by: Maximilian Weigand > > --- > > .../bindings/leds/backlight/lm3630a-backlight.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > index 3c9b4054ed9a..ef7ea0ad2d25 100644 > > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > @@ -33,6 +33,18 @@ properties: > > description: GPIO to use to enable/disable the backlight (HWEN pin). > > maxItems: 1 > > > > + ti,boost_use_1mhz: > > No underscores in property names. > > > + description: | > > Do not need '|' unless you need to preserve formatting. > > > + If present, change the boost converter switching frequency from the > > + default 500 kHz to 1 MHz. Refer to data sheet for hardware requirements. > > + type: boolean > > + > > + ti,boost_frequency_shift: > > + description: | > > + If present, change boost converter switching frequency from 500 kHz to > > + 560 kHz or from 1 Mhz to 1.12 Mhz, respectively. > > So just make it a property choosing the frequency, not bools, with > proper unit suffix. i.e. ti,boost-frequency-hz = ; with x being 500000, 560000, 1000000, 1120000 with the driver failing when the frequency is not achievable with the two knobs of 1mhz and shift.