dri-devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] Staging: fbtft: Fix wrong check in fbtft_write_wmem16_bus8()
@ 2019-07-15 14:30 Nicolas Saenz Julienne
       [not found] ` <7b8242ab-cc0c-d90b-60af-ff1c53789e44@opensynergy.com>
  0 siblings, 1 reply; 7+ messages in thread
From: Nicolas Saenz Julienne @ 2019-07-15 14:30 UTC (permalink / raw)
  To: linux-kernel
  Cc: preid, nishadkamdar, bhanusreemahesh, leobras.c,
	Nicolas Saenz Julienne, Greg Kroah-Hartman, dri-devel,
	linux-fbdev, devel

We actually want to set the gpio pin if it's avilable, not the other way
around.

Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
 drivers/staging/fbtft/fbtft-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 2ea814d0dca5..63c65dd67b17 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -135,7 +135,7 @@ int fbtft_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
 	remain = len / 2;
 	vmem16 = (u16 *)(par->info->screen_buffer + offset);
 
-	if (!par->gpio.dc)
+	if (par->gpio.dc)
 		gpiod_set_value(par->gpio.dc, 1);
 
 	/* non buffered write */
-- 
2.22.0

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 14:30 [PATCH] Staging: fbtft: Fix wrong check in fbtft_write_wmem16_bus8() Nicolas Saenz Julienne
     [not found] ` <7b8242ab-cc0c-d90b-60af-ff1c53789e44@opensynergy.com>
2019-07-15 14:58   ` [PATCH] Staging: fbtft: Fix wrong check in,fbtft_write_wmem16_bus8() Jan Sebastian Götte
2019-07-15 15:04     ` [PATCH] Staging: fbtft: Fix GPIO handling Jan Sebastian Götte
2019-07-15 15:14       ` Nicolas Saenz Julienne
2019-07-17 14:41     ` [PATCH v2] " Jan Sebastian Götte
2019-07-25  7:21       ` Greg KH
2019-07-25  7:23         ` Nicolas Saenz Julienne

dri-devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dri-devel/0 dri-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dri-devel dri-devel/ https://lore.kernel.org/dri-devel \
		dri-devel@lists.freedesktop.org
	public-inbox-index dri-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.dri-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git