From: "Christian König" <deathsimple@vodafone.de>
To: Felix Kuehling <felix.kuehling@amd.com>,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/amdgpu: Implement ttm_bo_driver.access_vram callback
Date: Mon, 17 Jul 2017 19:04:15 +0200 [thread overview]
Message-ID: <78d35e79-0c59-321a-7753-9bc2117a1c17@vodafone.de> (raw)
In-Reply-To: <ff877e3e-8ccf-5c41-d555-313f7dd1990d@amd.com>
Am 14.07.2017 um 21:44 schrieb Felix Kuehling:
> On 17-07-14 06:08 AM, Christian König wrote:
>> Am 13.07.2017 um 23:08 schrieb Felix Kuehling:
>> [SNIP]
>>> + result += bytes;
>>> + buf = (uint8_t *)buf + bytes;
>>> + pos += bytes;
>>> + len -= bytes;
>>> + if (pos >= (nodes->start + nodes->size) << PAGE_SHIFT) {
>>> + ++nodes;
>>> + pos = (nodes->start << PAGE_SHIFT);
> ... Here I handle crossing a node boundary. Yes, I actually added this
> case to my kfdtest unit test and made sure it works, along with all odd
> alignments that the code above handles.
Ah, I see. Sorry totally missed that chunk. In this case the patch is
Acked-by: Christian König <christian.koenig@amd.com>
Regards,
Christian.
>
> Regards,
> Felix
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-07-17 17:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 21:08 [PATCH 1/2] drm: Implement vm_operations_struct.access Felix Kuehling
[not found] ` <1499980105-7721-1-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2017-07-13 21:08 ` [PATCH 2/2] drm/amdgpu: Implement ttm_bo_driver.access_vram callback Felix Kuehling
[not found] ` <1499980105-7721-2-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2017-07-13 21:23 ` Felix Kuehling
2017-07-14 3:26 ` Michel Dänzer
2017-07-14 10:08 ` Christian König
[not found] ` <c25a37a9-8fae-11f0-cce6-59ca13412801-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-14 19:44 ` Felix Kuehling
2017-07-17 17:04 ` Christian König [this message]
2017-07-14 3:26 ` [PATCH 1/2] drm: Implement vm_operations_struct.access Michel Dänzer
[not found] ` <b377c150-e843-29ff-1be2-0e82f200abd6-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-07-14 19:47 ` Felix Kuehling
[not found] ` <a6bb7cda-5090-c88d-3309-003d601f1c46-5C7GfCeVMHo@public.gmane.org>
2017-07-15 3:32 ` Michel Dänzer
[not found] ` <48dc79df-f846-925c-ddf9-52852578201b-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-07-15 13:39 ` Christian König
2017-07-14 10:06 ` Christian König
[not found] ` <8b708b8e-cf4f-d553-811f-a7849fbf6eff-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-07-14 19:46 ` Felix Kuehling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d35e79-0c59-321a-7753-9bc2117a1c17@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).