From: Lyude Paul <lyude@redhat.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>, Dave Airlie <airlied@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vblank: Fix -Wformat compile warnings on some arches
Date: Fri, 22 May 2020 14:18:21 -0400 [thread overview]
Message-ID: <7db8ff3ee32bddfb6f82760468caa86388bee9bd.camel@redhat.com> (raw)
In-Reply-To: <20200521210924.GA1056842@ravnborg.org>
On Thu, 2020-05-21 at 23:09 +0200, Sam Ravnborg wrote:
> On Thu, May 21, 2020 at 04:46:47PM -0400, Lyude Paul wrote:
> > On some architectures like ppc64le and aarch64, compiling with
> > -Wformat=1 will throw the following warnings:
> >
> > In file included from drivers/gpu/drm/drm_vblank.c:33:
> > drivers/gpu/drm/drm_vblank.c: In function 'drm_update_vblank_count':
> > drivers/gpu/drm/drm_vblank.c:273:16: warning: format '%llu' expects
> > argument of type 'long long unsigned int', but argument 4 has type
> > 'long int' [-Wformat=]
> > DRM_DEBUG_VBL("updating vblank count on crtc %u:"
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ./include/drm/drm_print.h:407:22: note: in definition of macro
> > 'DRM_DEBUG_VBL'
> > drm_dbg(DRM_UT_VBL, fmt, ##__VA_ARGS__)
> > ^~~
> > drivers/gpu/drm/drm_vblank.c:274:22: note: format string is defined here
> > " current=%llu, diff=%u, hw=%u hw_last=%u\n",
> > ~~~^
> > %lu
> >
> > So, fix that with a typecast.
> >
> > Signed-off-by: Lyude Paul <lyude@redhat.com>
> > Co-developed-by: Dave Airlie <airlied@redhat.com>
> > ---
> > drivers/gpu/drm/drm_vblank.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
> > index acb3c3f65b579..1a96db2dd16fa 100644
> > --- a/drivers/gpu/drm/drm_vblank.c
> > +++ b/drivers/gpu/drm/drm_vblank.c
> > @@ -342,7 +342,7 @@ static void drm_update_vblank_count(struct drm_device
> > *dev, unsigned int pipe,
> >
> > DRM_DEBUG_VBL("updating vblank count on crtc %u:"
> > " current=%llu, diff=%u, hw=%u hw_last=%u\n",
> > - pipe, atomic64_read(&vblank->count), diff,
> > + pipe, (unsigned long long)atomic64_read(&vblank->count),
> > diff,
> > cur_vblank, vblank->last);
>
> While touching this you could consider introducing drm_dbg_vbl().
> An maybe as a follow-up patch replace all logging in this file with the drm_*
> variants.
ok - no promises when I can actually get to this though, I've got a lot on my
plate ATM
>
> Sam
>
> >
> > if (diff == 0) {
> > --
> > 2.26.2
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-22 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 20:46 [PATCH] drm/vblank: Fix -Wformat compile warnings on some arches Lyude Paul
2020-05-21 21:09 ` Sam Ravnborg
2020-05-22 18:18 ` Lyude Paul [this message]
2020-05-23 6:54 ` Sam Ravnborg
2020-05-22 6:30 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7db8ff3ee32bddfb6f82760468caa86388bee9bd.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).