From: Bhawanpreet Lakha <Bhawanpreet.lakha@amd.com>
To: Lyude Paul <lyude@redhat.com>,
Jerry.Zuo@amd.com, dri-devel@lists.freedesktop.org
Cc: Harry.Wentland@amd.com, Wayne.Lin@amd.com,
Nicholas.Kazlauskas@amd.com, "Lipski,
Mikita" <Mikita.Lipski@amd.com>
Subject: Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format
Date: Mon, 18 Oct 2021 15:47:05 -0400 [thread overview]
Message-ID: <7e2abaa7-ca3a-6da9-6e43-772ce287f674@amd.com> (raw)
In-Reply-To: <2a71120b01c96c942cdaba4ad6c0a0bbbd2d91e2.camel@redhat.com>
I understand the mst_state argument its just that most of the mst
functions are using mst_mgr/port structs and there is no easy way to
extract the mst_state using mgr/port in these places
(drm_dp_update_payload_part1, drm_dp_mst_allocate_vcpi, drm_dp_init_vcpi
etc) where we need the slot info.
So either we need to keep a copy of the slots in the mgr because that's
what most of the code is using right now or pass around the atomic state
to get the mgr->state mapping. (I don't have much experience with the
mst code so maybe I am missing some key detail here?)
Thanks,
Bhawan
On 2021-10-15 4:41 p.m., Lyude Paul wrote:
> [more snip]
>
> On Fri, 2021-10-15 at 15:43 -0400, Bhawanpreet Lakha wrote:
>> Thanks for the response,
>>
>> That function is per port so not sure how that will work. Also we only
>> need to check this inside drm_dp_mst_atomic_check_vcpi_alloc_limit(),
>> which doesn't have a state.
>>
>> We could add the slots(or some DP version indicator) inside the
>> drm_connector, and add a parameter to
>> drm_dp_mst_atomic_check_vcpi_alloc_limit(int slots)? and call it with
>> this info via drm_dp_mst_atomic_check() and then update the mgr->slot in
>> commit.
> TBH - I think we can actually just get away with having all of this info in
> drm_dp_mst_topology_state
>
>>
>> Bhawan
>>
>>>> ret = drm_dp_mst_atomic_check_mstb_bw_limit(mgr-
>>>>> mst_primary,
>>>> mst_state);
>>>> mutex_unlock(&mgr->lock);
>>>> @@ -5527,11 +5543,16 @@ int drm_dp_mst_topology_mgr_init(struct
>>>> drm_dp_mst_topology_mgr *mgr,
>>>> if (!mgr->proposed_vcpis)
>>>> return -ENOMEM;
>>>> set_bit(0, &mgr->payload_mask);
>>>> + mgr->total_avail_slots = 63;
>>>> + mgr->start_slot = 1;
>>>>
>>>> mst_state = kzalloc(sizeof(*mst_state), GFP_KERNEL);
>>>> if (mst_state == NULL)
>>>> return -ENOMEM;
>>>>
>>>> + mst_state->total_avail_slots = 63;
>>>> + mst_state->start_slot = 1;
>>>> +
>>>> mst_state->mgr = mgr;
>>>> INIT_LIST_HEAD(&mst_state->vcpis);
>>>>
>>>> diff --git a/include/drm/drm_dp_mst_helper.h
>>>> b/include/drm/drm_dp_mst_helper.h
>>>> index ddb9231d0309..f8152dfb34ed 100644
>>>> --- a/include/drm/drm_dp_mst_helper.h
>>>> +++ b/include/drm/drm_dp_mst_helper.h
>>>> @@ -554,6 +554,8 @@ struct drm_dp_mst_topology_state {
>>>> struct drm_private_state base;
>>>> struct list_head vcpis;
>>>> struct drm_dp_mst_topology_mgr *mgr;
>>>> + u8 total_avail_slots;
>>>> + u8 start_slot;
>>>> };
>>>>
>>>> #define to_dp_mst_topology_mgr(x) container_of(x, struct
>>>> drm_dp_mst_topology_mgr, base)
>>>> @@ -661,6 +663,16 @@ struct drm_dp_mst_topology_mgr {
>>>> */
>>>> int pbn_div;
>>>>
>>>> + /**
>>>> + * @total_avail_slots: 63 for 8b/10b, 64 for 128/132b
>>>> + */
>>>> + u8 total_avail_slots;
>>>> +
>>>> + /**
>>>> + * @start_slot: 1 for 8b/10b, 0 for 128/132b
>>>> + */
>>>> + u8 start_slot;
>>>> +
>>>> /**
>>>> * @funcs: Atomic helper callbacks
>>>> */
>>>> @@ -806,6 +818,7 @@ int drm_dp_mst_get_vcpi_slots(struct
>>>> drm_dp_mst_topology_mgr *mgr, struct drm_dp
>>>>
>>>> void drm_dp_mst_reset_vcpi_slots(struct drm_dp_mst_topology_mgr *mgr,
>>>> struct drm_dp_mst_port *port);
>>>>
>>>> +void drm_dp_mst_update_coding_cap(struct drm_dp_mst_topology_state
>>>> *mst_state, uint8_t link_coding_cap);
>>>>
>>>> void drm_dp_mst_deallocate_vcpi(struct drm_dp_mst_topology_mgr *mgr,
>>>> struct drm_dp_mst_port *port);
next prev parent reply other threads:[~2021-10-18 19:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 23:43 [PATCH 0/2] Update 128b/132b MST Slot Information Fangzhi Zuo
2021-08-27 23:43 ` [PATCH 1/2] drm: Update MST First Link Slot Information Based on Encoding Format Fangzhi Zuo
2021-08-28 4:09 ` kernel test robot
2021-08-30 20:00 ` Lyude Paul
2021-08-31 19:44 ` Zuo, Jerry
2021-08-31 20:19 ` Lyude Paul
2021-08-31 22:44 ` Lyude Paul
2021-10-12 21:58 ` [PATCH] " Bhawanpreet Lakha
2021-10-12 22:02 ` Lakha, Bhawanpreet
2021-10-12 22:09 ` Lyude Paul
2021-10-13 16:09 ` Jani Nikula
2021-10-13 19:33 ` Bhawanpreet Lakha
2021-10-13 19:37 ` Lyude Paul
2021-10-13 18:52 ` kernel test robot
2021-10-13 21:54 ` kernel test robot
2021-10-13 22:25 ` Lyude Paul
2021-10-14 20:21 ` Bhawanpreet Lakha
2021-10-14 20:22 ` Bhawanpreet Lakha
2021-10-15 20:04 ` Lyude Paul
2021-10-15 19:43 ` Bhawanpreet Lakha
2021-10-15 20:41 ` Lyude Paul
2021-10-18 19:47 ` Bhawanpreet Lakha [this message]
2021-10-18 23:17 ` Lyude Paul
2021-10-19 18:01 ` [PATCH 2/4] " Bhawanpreet Lakha
2021-10-20 8:34 ` Jani Nikula
2021-08-31 22:45 ` [PATCH 1/2] " Lyude Paul
2021-08-31 22:46 ` Lyude Paul
2021-08-27 23:43 ` [PATCH 2/2] drm/amdgpu: Example Usage in AMDGPU Fangzhi Zuo
2021-08-28 11:54 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-03-26 3:14 [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format Fangzhi Zuo
2021-03-26 16:48 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e2abaa7-ca3a-6da9-6e43-772ce287f674@amd.com \
--to=bhawanpreet.lakha@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Jerry.Zuo@amd.com \
--cc=Mikita.Lipski@amd.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lyude@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).