Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void

From: Helge Deller <deller@gmx.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Stephen Kitt <steve@sk2.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Tony Lindgren <tony@atomide.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Javier Martinez Canillas <javierm@redhat.com>,
	Wang Qing <wangqing@vivo.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Peter Jones <pjones@redhat.com>,
	Xuezhi Zhang <zhangxuezhi1@coolpad.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Gaosheng Cui <cuigaosheng1@huawei.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Alexander Shiyan <shc_work@mail.ru>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Xu Panda <xu.panda@zte.com.cn>,
	Michal Simek <michal.simek@xilinx.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Dongliang Mu <dzm91@hust.edu.cn>,
	NXP Linux Team <linux-imx@nxp.com>,
	Yang Yingliang <yangyingliang@huawei.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Arnd Bergmann <arnd@arndb.de>,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Yu Zhe <yuzhe@nfschina.com>, ye xingchen <ye.xingchen@zte.com.cn>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	Zeng Heng <zengheng4@huawei.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Brown <broonie@kernel.org>, Hyunwoo Kim <imv4bel@gmail.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Yihao Han <hanyihao@vivo.com>, Timur Tabi <timur@kernel.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Zhang Qilong <zhangqilong3@huawei.com>,
	Kristoffer Ericson <kristoffer.ericson@gmail.com>,
	kernel@pengutronix.de, Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
Date: Tue, 30 May 2023 18:34:40 +0200	[thread overview]
Message-ID: <7eed2e10-05af-1ebc-1285-eb17b3113183@gmx.de> (raw)
In-Reply-To: <20230530162728.sexlrqhkoflvuu7m@pengutronix.de>

On 5/30/23 18:27, Uwe Kleine-König wrote:
> Hello Helge,
>
> On Tue, May 30, 2023 at 06:12:09PM +0200, Helge Deller wrote:
>> Btw... I cleaned up some minor whitespace issues in patch 3 (au1100fb).
>
> We both did some different cleanup, on top of your
> 87be5a5d9a5c5b00505181eedbee62134f07d11d we could further cleanup doing
>
> diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
> index fb38557a9b63..648d6cac86e8 100644
> --- a/drivers/video/fbdev/au1100fb.c
> +++ b/drivers/video/fbdev/au1100fb.c
> @@ -590,7 +590,7 @@ static struct platform_driver au1100fb_driver = {
>   	.probe		= au1100fb_drv_probe,
>   	.remove_new	= au1100fb_drv_remove,
>   	.suspend	= au1100fb_drv_suspend,
> -        .resume		= au1100fb_drv_resume,
> +	.resume		= au1100fb_drv_resume,
>   };
>   module_platform_driver(au1100fb_driver);
>
> Feel free to squash this into 87be5a5d9a5c5b00505181eedbee62134f07d11d.
> If you want to apply it separately, either tell me to post a proper
> patch, or apply it under your name with my Suggested-by -- whatever
> suits you best.

I've squashed it into your patch.

Thanks!
Helge