From: Iago Toral <itoral@igalia.com>
To: "Maíra Canal" <mcanal@igalia.com>,
"Emma Anholt" <emma@anholt.net>, "Melissa Wen" <mwen@igalia.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/v3d: wait for all jobs to finish before unregistering
Date: Tue, 24 Oct 2023 07:57:51 +0200 [thread overview]
Message-ID: <807b6fd6f6100c7cd824f4aa1a80ec1421d7222c.camel@igalia.com> (raw)
In-Reply-To: <20231023105927.101502-1-mcanal@igalia.com>
El lun, 23-10-2023 a las 07:58 -0300, Maíra Canal escribió:
> Currently, we are only warning the user if the BIN or RENDER jobs
> don't
> finish before we unregister V3D. We must wait for all jobs to finish
> before unregistering. Therefore, warn the user if TFU or CSD jobs
> are not done by the time the driver is unregistered.
>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
> drivers/gpu/drm/v3d/v3d_gem.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c
> b/drivers/gpu/drm/v3d/v3d_gem.c
> index 2e94ce788c71..afa7d170d1ff 100644
> --- a/drivers/gpu/drm/v3d/v3d_gem.c
> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
> @@ -1072,6 +1072,8 @@ v3d_gem_destroy(struct drm_device *dev)
> */
> WARN_ON(v3d->bin_job);
> WARN_ON(v3d->render_job);
> + WARN_ON(v3d->tfu_job);
> + WARN_ON(v3d->csd_job);
I guess we should do this for cache clean jobs too, right?
Iago
>
> drm_mm_takedown(&v3d->mm);
>
next prev parent reply other threads:[~2023-10-24 5:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 10:58 [PATCH 1/2] drm/v3d: wait for all jobs to finish before unregistering Maíra Canal
2023-10-23 10:58 ` [PATCH 2/2] drm/v3d: assure that the job is NULL after being freed Maíra Canal
2023-10-24 5:57 ` Iago Toral [this message]
2023-10-24 10:05 ` [PATCH 1/2] drm/v3d: wait for all jobs to finish before unregistering Maira Canal
2023-10-30 12:20 ` Iago Toral
2023-10-30 12:42 ` Maira Canal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=807b6fd6f6100c7cd824f4aa1a80ec1421d7222c.camel@igalia.com \
--to=itoral@igalia.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).