dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Sandy Huang <hjc@rock-chips.com>,
	dri-devel@lists.freedesktop.org,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a
Date: Mon, 9 May 2022 21:49:16 +0200	[thread overview]
Message-ID: <812AC0DB-A6D0-4DA3-BCDC-7743E8F61821@gmail.com> (raw)
In-Reply-To: <CAMdYzYrz7DRj7F9hGaAPaTSiZkQ4eMNujAp8uPuE9geL6kAz4g@mail.gmail.com>

> 
> If you want to confirm the hardware is configured correctly you can
> remove the cec pin from the hdmi node and set up a cec-gpio node.
> https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/devicetree/bindings/media/cec-gpio.txt
> 
> For some reason the board developers decided to make this selectable,
> check the location of R90652 and R90653.
> 

Peter,

my board is v1.31 and is using HDMITX_CEC_M1 i think.
I verified this by temp. changing to HDMITX_CEC_M0

For M1:
2022-05-09 21:12:37.130188 I  CECAdapter: Using physical address 1.0.0.0 from EDID
2022-05-09 21:12:37.173267 I  CECAdapter: Found 1 CEC devices(s).
2022-05-09 21:12:37.173299 I  CECAdapter: Device 1: path '/dev/cec0' com port 'Linux' SELECTED
2022-05-09 21:12:37.173307 I  CECAdapter: Trying to open device /dev/cec0 (Linux).
2022-05-09 21:12:37.180095 I  CECAdapter: connection opened
2022-05-09 21:12:37.545229 I  CECAdapter: setting HDMI port to 1 on device TV (0)
2022-05-09 21:12:37.904145 I  CECAdapter: >> source deactivated: Playback 1 (4)
2022-05-09 21:12:37.904311 I  CECAdapter: Source 4 Deactivated
2022-05-09 21:12:38.284452 I  CECAdapter: >> source activated: Playback 1 (4)
2022-05-09 21:12:38.284492 I  CECAdapter: Source 4 Activated
2022-05-09 21:12:38.284694 I  CECAdapter: CEC client registered: libCEC version = 6.0.2, client version = 6.0.2, firmware version = 0, logical address(es) = Playback 1 (4) , physical address: 1.0.0.0, git revision: v12.0.0-v32.0-16-g611cac15cc+59-07dc900~dirty, compiled on 2022-04-23 05:50:57 by piotro@/bin/sh: hostname: command not found on Linux 5.16.14-arch1-4 (x86_64), features: P8_USB, DRM, P8_detect, randr, Linux
2022-05-09 21:12:38.519394 I  CECAdapter: Opened CEC device.
2022-05-09 21:12:38.636950 I  CECAdapter: << powering on 'TV' (0)
2022-05-09 21:12:38.754023 E  CECAdapter: Failed to turn TV on.
2022-05-09 21:12:38.754313 I  CECAdapter: >> source activated: Playback 1 (4)
2022-05-09 21:12:38.754343 I  CECAdapter: Source 4 Activated
2022-05-09 21:12:38.872079 I  CECAdapter: << Playback 1 (4) -> broadcast (F): active source (1000)
2022-05-09 21:12:38.974698 I  CECAdapter: Asked TV to switch to this input.
2022-05-09 21:13:07.292069 W  CECAdapter: CEC device can't poll TV: TV does not respond to CEC polls
2022-05-09 21:13:37.296372 W  CECAdapter: CEC device can't poll TV: TV does not respond to CEC polls 

for M0:
2022-05-09 21:37:47.632175 I  CECAdapter: Using physical address 1.0.0.0 from EDID
2022-05-09 21:37:47.680618 I  CECAdapter: Found 1 CEC devices(s).
2022-05-09 21:37:47.680644 I  CECAdapter: Device 1: path '/dev/cec0' com port 'Linux' SELECTED
2022-05-09 21:37:47.680654 I  CECAdapter: Trying to open device /dev/cec0 (Linux).
2022-05-09 21:37:47.694974 I  CECAdapter: connection opened
2022-05-09 21:37:56.341846 I  CECAdapter: setting HDMI port to 1 on device TV (0)
2022-05-09 21:38:17.675457 I  CECAdapter: >> source activated: Playback 1 (4)
2022-05-09 21:38:17.675561 I  CECAdapter: Source 4 Activated
2022-05-09 21:38:17.675657 I  CECAdapter: CEC client registered: libCEC version = 6.0.2, client version = 6.0.2, firmware version = 0, logical address(es) = Playback 1 (4) , physical address: 1.0.0.0, git revision: v12.0.0-v32.0-16-g611cac15cc+59-07dc900~dirty, compiled on 2022-04-23 05:50:57 by piotro@/bin/sh: hostname: command not found on Linux 5.16.14-arch1-4 (x86_64), features: P8_USB, DRM, P8_detect, randr, Linux
2022-05-09 21:38:30.475336 I  CECAdapter: Opened CEC device.
2022-05-09 21:38:34.741846 I  CECAdapter: << Playback 1 (4) -> broadcast (F): active source (1000)
2022-05-09 21:38:39.008432 I  CECAdapter: << powering on 'TV' (0)
2022-05-09 21:38:39.008506 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22
2022-05-09 21:38:39.008526 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22
2022-05-09 21:38:43.275094 E  CECAdapter: Failed to turn TV on.
2022-05-09 21:38:43.275201 I  CECAdapter: >> source activated: Playback 1 (4)
2022-05-09 21:38:43.275224 I  CECAdapter: Source 4 Activated
2022-05-09 21:38:43.275375 W  CECAdapter: CEC device can't poll TV: TV does not respond to CEC polls
2022-05-09 21:38:47.541811 I  CECAdapter: << Playback 1 (4) -> broadcast (F): active source (1000)
2022-05-09 21:38:47.541898 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22
2022-05-09 21:38:47.541909 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22
2022-05-09 21:38:47.541924 E  CECAdapter: Failed to switch to this input.
2022-05-09 21:38:51.808626 I  CECAdapter: << Playback 1 (4) -> broadcast (F): active source (1000)
2022-05-09 21:38:51.808722 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22
2022-05-09 21:38:51.808735 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22
2022-05-09 21:38:57.142091 I  CECAdapter: << Playback 1 (4) -> broadcast (F): active source (1000)
2022-05-09 21:38:57.142109 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22
2022-05-09 21:38:57.142117 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22
2022-05-09 21:39:02.475097 I  CECAdapter: << Playback 1 (4) -> broadcast (F): active source (1000)
2022-05-09 21:39:02.475115 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22
2022-05-09 21:39:02.475123 E  CECAdapter: CLinuxCECAdapterCommunication::Write - ioctl CEC_TRANSMIT failed - tx_status=00 errno=22

> I have some concerns about the DTS you've built here. For instance how
> come you are modifying the power domains?

This was experiment as I was advised:

"32k clock needed for cec and this clock is generated by the rtc which is embedded in the rk8xx regulator.
So you should make sure it is enabled when hdmi is powerd on, eg adding it to the RK3568_PD_VO powerdomain should help"

power domains entries in dts was attempt to play with above cec clock sugestion.

M0/M1 logs in this email are from cleaned dts: https://pastebin.com/0pgwpdsS

> USB3 is broken because the rock3-a is a rk3568 device and you're
> missing combophy0.

Perfect. all 4 usb ports are now working.
Also no errors in dmesg. 
Thx!


  reply	other threads:[~2022-05-09 19:49 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22  7:28 [PATCH v11 00/24] drm/rockchip: RK356x VOP2 support Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 01/24] clk: rk3568: Mark hclk_vo as critical Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 02/24] drm/rockchip: Embed drm_encoder into rockchip_decoder Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 03/24] drm/rockchip: Add crtc_endpoint_id to rockchip_encoder Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 04/24] drm/rockchip: dw_hdmi: rename vpll clock to reference clock Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 05/24] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 06/24] arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref' Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 07/24] drm/rockchip: dw_hdmi: add rk3568 support Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 08/24] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 09/24] drm/rockchip: dw_hdmi: add regulator support Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 10/24] dt-bindings: display: rockchip: dw-hdmi: Add " Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 11/24] drm/rockchip: dw_hdmi: Use auto-generated tables Sascha Hauer
2022-05-03 11:02   ` Heiko Stübner
2022-05-03 12:17     ` Robin Murphy
2022-04-22  7:28 ` [PATCH v11 12/24] drm/rockchip: dw_hdmi: relax mode_valid hook Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 13/24] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 14/24] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 15/24] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 16/24] arm64: dts: rockchip: rk356x: Add VOP2 nodes Sascha Hauer
2022-05-05  0:28   ` Heiko Stübner
2022-05-05  6:41     ` Sascha Hauer
2022-05-05  7:23       ` Heiko Stübner
2022-05-06  7:10         ` Sascha Hauer
2022-05-06  8:54           ` Heiko Stuebner
2022-04-22  7:28 ` [PATCH v11 17/24] arm64: dts: rockchip: rk356x: Add HDMI nodes Sascha Hauer
2022-05-05  8:45   ` Aw: " Frank Wunderlich
2022-05-05  9:05     ` Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 18/24] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 19/24] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a Sascha Hauer
2022-05-08 13:40   ` Piotr Oniszczuk
2022-05-08 16:53     ` Peter Geis
2022-05-08 17:36       ` Piotr Oniszczuk
2022-05-08 18:00         ` Peter Geis
2022-05-08 18:21           ` Piotr Oniszczuk
2022-05-09 16:00             ` Peter Geis
2022-05-09 19:49               ` Piotr Oniszczuk [this message]
2022-05-10  1:35                 ` Peter Geis
2022-05-10  7:29                   ` Piotr Oniszczuk
2022-05-10 12:08                     ` Peter Geis
2022-05-10 13:49                       ` Piotr Oniszczuk
2022-05-10 20:54                         ` Peter Geis
2022-05-10 22:49                           ` Peter Geis
2022-05-11 16:17                             ` Piotr Oniszczuk
2022-05-14 13:58               ` Piotr Oniszczuk
2022-06-24  8:29                 ` Piotr Oniszczuk
2022-06-24 12:40                   ` Peter Geis
2022-06-24 18:57                     ` Piotr Oniszczuk
2022-06-24 23:50                       ` Peter Geis
2022-06-25 13:18                         ` Piotr Oniszczuk
2022-06-25 14:00                           ` Peter Geis
2022-06-25 15:31                             ` Piotr Oniszczuk
2022-07-10 17:01                               ` Piotr Oniszczuk
2022-07-11 10:41                               ` Robin Murphy
2022-07-11 11:04                                 ` Piotr Oniszczuk
2022-07-11 11:34                                   ` Robin Murphy
2022-05-12 12:17       ` Robin Murphy
2022-05-12 13:01         ` Peter Geis
2022-04-22  7:28 ` [PATCH v11 21/24] drm/rockchip: Make VOP driver optional Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 22/24] drm: rockchip: Add VOP2 driver Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 23/24] dt-bindings: display: rockchip: Add binding for VOP2 Sascha Hauer
2022-04-22  7:28 ` [PATCH v11 24/24] dt-bindings: display: rockchip: dw-hdmi: fix ports description Sascha Hauer
2022-04-25 12:34 ` [PATCH v11 00/24] drm/rockchip: RK356x VOP2 support Michael Riesch
2022-04-25 14:48 ` Daniel Stone
2022-05-03  9:12 ` (subset) " Heiko Stuebner
2022-05-03  9:26 ` Heiko Stuebner
2022-05-03  9:29 ` Heiko Stuebner
2022-05-03 11:02 ` Heiko Stuebner
2022-05-04 12:08 ` Heiko Stuebner
2022-05-17 18:22 ` Heiko Stuebner
2022-05-17 18:27 ` Heiko Stuebner
2022-05-20 10:02   ` Maya Matuszczyk
2022-05-20 10:12     ` Sascha Hauer
2022-05-20 11:56       ` Peter Geis
2022-05-20 12:15         ` Maya Matuszczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=812AC0DB-A6D0-4DA3-BCDC-7743E8F61821@gmail.com \
    --to=piotr.oniszczuk@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=michael.riesch@wolfvision.net \
    --cc=pgwipeout@gmail.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).