From: Hans Verkuil <hverkuil@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 00/11] drm/sun4i: add CEC support
Date: Tue, 11 Jul 2017 22:10:46 +0200 [thread overview]
Message-ID: <8221b85d-d50a-5f99-0128-c48a23b6f569@xs4all.nl> (raw)
In-Reply-To: <20170711063044.29849-1-hverkuil@xs4all.nl>
On 11/07/17 08:30, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> This patch series adds CEC support for the sun4i HDMI controller.
>
> The CEC hardware support for the A10 is very low-level as it just
> controls the CEC pin. Since I also wanted to support GPIO-based CEC
> hardware most of this patch series is in the CEC framework to
> add a generic low-level CEC pin framework. It is only the final patch
> that adds the sun4i support.
>
> This patch series first makes some small changes in the CEC framework
> (patches 1-4) to prepare for this CEC pin support.
>
> Patch 5-7 adds the new API elements and documents it. Patch 6 reworks
> the CEC core event handling.
>
> Patch 8 adds pin monitoring support (allows userspace to see all
> CEC pin transitions as they happen).
>
> Patch 9 adds the core cec-pin implementation that translates low-level
> pin transitions into valid CEC messages. Basically this does what any
> SoC with a proper CEC hardware implementation does.
>
> Patch 10 documents the cec-pin kAPI (and also the cec-notifier kAPI
> which was missing).
>
> Finally patch 11 adds the actual sun4i_hdmi CEC implementation.
>
> I tested this on my cubieboard. There were no errors at all
> after 126264 calls of 'cec-ctl --give-device-vendor-id' while at the
> same time running a 'make -j4' of the v4l-utils git repository and
> doing a continuous scp to create network traffic.
>
> This patch series is based on top of the mainline kernel as of
> yesterday (so with all the sun4i and cec patches for 4.13 merged).
>
> Maxime, patches 1-10 will go through the media subsystem. How do you
> want to handle the final patch? It can either go through the media
> subsystem as well, or you can sit on it and handle this yourself during
> the 4.14 merge window. Another option is to separate the Kconfig change
> into its own patch. That way you can merge the code changes and only
> have to handle the Kconfig patch as a final change during the merge
> window.
I forgot to mention that if you want to use pin monitoring, then the
updated cec-ctl is found here:
https://git.linuxtv.org/hverkuil/v4l-utils.git/log/?h=cec-mon-pin2
To start pin monitoring run:
sudo cec-ctl --monitor-pin
Add the -v flag to see each bit transition.
When in pin monitoring mode it will analyze the low-level protocol and
warn for incorrect bit periods, etc. To be really accurate the CPU should
be lightly loaded.
Regards,
Hans
>
> Regards,
>
> Hans
>
> Hans Verkuil (11):
> cec: improve transmit timeout logging
> cec: add *_ts variants for transmit_done/received_msg
> cec: add adap_free op
> cec-core.rst: document the adap_free callback
> linux/cec.h: add pin monitoring API support
> cec: rework the cec event handling
> cec: document the new CEC pin capability, events and mode
> cec: add core support for low-level CEC pin monitoring
> cec-pin: add low-level pin hardware support
> cec-core.rst: include cec-pin.h and cec-notifier.h
> sun4i_hdmi: add CEC support
>
> Documentation/media/kapi/cec-core.rst | 40 ++
> .../media/uapi/cec/cec-ioc-adap-g-caps.rst | 7 +
> Documentation/media/uapi/cec/cec-ioc-dqevent.rst | 20 +
> Documentation/media/uapi/cec/cec-ioc-g-mode.rst | 19 +-
> drivers/gpu/drm/sun4i/Kconfig | 9 +
> drivers/gpu/drm/sun4i/sun4i_hdmi.h | 8 +
> drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 57 +-
> drivers/media/Kconfig | 3 +
> drivers/media/cec/Makefile | 4 +
> drivers/media/cec/cec-adap.c | 196 +++--
> drivers/media/cec/cec-api.c | 73 +-
> drivers/media/cec/cec-core.c | 2 +
> drivers/media/cec/cec-pin.c | 794 +++++++++++++++++++++
> include/media/cec-pin.h | 183 +++++
> include/media/cec.h | 64 +-
> include/uapi/linux/cec.h | 8 +-
> 16 files changed, 1389 insertions(+), 98 deletions(-)
> create mode 100644 drivers/media/cec/cec-pin.c
> create mode 100644 include/media/cec-pin.h
>
next prev parent reply other threads:[~2017-07-11 20:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 6:30 [PATCH 00/11] drm/sun4i: add CEC support Hans Verkuil
2017-07-11 6:30 ` [PATCH 01/11] cec: improve transmit timeout logging Hans Verkuil
2017-07-11 6:30 ` [PATCH 02/11] cec: add *_ts variants for transmit_done/received_msg Hans Verkuil
2017-07-11 6:30 ` [PATCH 03/11] cec: add adap_free op Hans Verkuil
2017-07-11 6:30 ` [PATCH 04/11] cec-core.rst: document the adap_free callback Hans Verkuil
2017-07-11 6:30 ` [PATCH 05/11] linux/cec.h: add pin monitoring API support Hans Verkuil
2017-07-11 6:30 ` [PATCH 06/11] cec: rework the cec event handling Hans Verkuil
2017-07-11 6:30 ` [PATCH 07/11] cec: document the new CEC pin capability, events and mode Hans Verkuil
2017-07-11 6:30 ` [PATCH 08/11] cec: add core support for low-level CEC pin monitoring Hans Verkuil
2017-07-11 6:30 ` [PATCH 09/11] cec-pin: add low-level pin hardware support Hans Verkuil
2017-07-11 6:30 ` [PATCH 10/11] cec-core.rst: include cec-pin.h and cec-notifier.h Hans Verkuil
2017-07-11 6:30 ` [PATCH 11/11] sun4i_hdmi: add CEC support Hans Verkuil
2017-07-11 20:10 ` Hans Verkuil [this message]
2017-07-11 20:39 ` [PATCH 00/11] drm/sun4i: " Maxime Ripard
2017-07-11 21:06 ` Hans Verkuil
2017-07-18 16:29 ` Maxime Ripard
2017-07-19 8:39 ` Hans Verkuil
2017-09-08 10:59 ` Hans Verkuil
2017-09-21 20:37 ` Maxime Ripard
2017-09-21 21:19 ` Hans Verkuil
2017-09-22 6:50 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8221b85d-d50a-5f99-0128-c48a23b6f569@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).