From: Thomas Zimmermann <tzimmermann@suse.de>
To: Emil Velikov <emil.l.velikov@gmail.com>,
kernel test robot <rong.a.chen@intel.com>
Cc: john.p.donnelly@oracle.com,
ML dri-devel <dri-devel@lists.freedesktop.org>,
lkp@lists.01.org, OTC LSE PnP <otc.lse.pnp@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Dave Airlie <airlied@redhat.com>, Sam Ravnborg <sam@ravnborg.org>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [drm/mgag200] e44e907dd8: phoronix-test-suite.glmark2.800x600.score -64.9% regression
Date: Tue, 16 Jun 2020 16:24:30 +0200 [thread overview]
Message-ID: <8345c20c-4794-87d5-4464-c284b8e9cf73@suse.de> (raw)
In-Reply-To: <CACvgo50e5ddtqWfcBiB9b05XGVuTz=8m4yH7BvAqwV2mKcuupA@mail.gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 5535 bytes --]
Hi
Am 15.06.20 um 22:58 schrieb Emil Velikov:
> Hi all,
>
> On Thu, 4 Jun 2020 at 08:11, kernel test robot <rong.a.chen@intel.com> wrote:
>>
>> Greeting,
>>
>> FYI, we noticed a -64.9% regression of phoronix-test-suite.glmark2.800x600.score due to commit:
>>
> On one hand, I'm really happy to see performance testing happening
> although this report is missing various crucial pieces of information.
>
>> commit: e44e907dd8f937313d35615d799d54162c56d173 ("[PATCH v3 05/15] drm/mgag200: Split MISC register update into PLL selection, SYNC and I/O")
>> url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-mgag200-Convert-to-atomic-modesetting/20200515-163744
>> base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
>>
>> in testcase: phoronix-test-suite
>> on test machine: 16 threads Intel(R) Xeon(R) CPU X5570 @ 2.93GHz with 48G memory
>> with following parameters:
>>
>> need_x: true
> Replace "need_x" with the Xorg version as seen in `Xorg -version'.
>
>> test: glmark2-1.1.0
>> cpufreq_governor: performance
>> ucode: 0x1d
>>
>> test-description: The Phoronix Test Suite is the most comprehensive testing and benchmarking platform available that provides an extensible framework for which new tests can be easily added.
>> test-url: http://www.phoronix-test-suite.com/
>>
> Please remove the test description and url. They don't add any value.
>
> Mention which Mesa version is used as well as on what GPU. The output
> of lspci and glxinfo will help here.
>
> For this particular test - there is no Mesa/upstream driver for this
> GPU, so I imagine one of the swrast drivers was used. Which one -
> swrast (classic, softpipe, llvmpipe, swr) or kms_swrast.
> The output of `LD_DEBUG=libs glxinfo |& grep _dri.so` will help here.
>
>> commit:
>> bef2303526 ("drm/mgag200: Move mode-setting code into separate helper function")
>> e44e907dd8 ("drm/mgag200: Split MISC register update into PLL selection, SYNC and I/O")
>>
>
> Actually the offending commit has a subtle change of behaviour - it
> adds an extra MGAREG_MISC_RAMMAPEN.
> That is not documented and I've failed to spot it during review.
>
> Thomas - shall we revert that line in itself or at least add an inline
> comment why it is needed?
Oh, well spotted. I'll send out a patch to not set the bit. Hopefully
this will resolve the problem.
>
>>
>> 100 +---------------------------------------------------------------------+
>> 90 |-+ + + +.+ + + + + + : |
>> | : : : : : : : : : : : |
>> 80 |-: : : : : : : : : : : |
>> 70 |-:: : :: : : : :: :: : :: : |
>> |: : : : : : : : : : : : : : : : : : : |
>> 60 |:+: : : : : : : : : : : : : : : : : : |
>> 50 |:+: : : : : : : : : : : : : : : : : : |
>> 40 |:+ : : : : : : : : : : : : : : : : : : |
>> |: : : : : : : : : : : : : : : : : : :O O O O O |
>> 30 |:+ : : : : : : : : : : : : : : : : : : |
>> 20 |-+ :: : : : : : :: : : :: : : O : |
>> | : : : : : : : : : : : : : |
>> 10 |-+ : : : : : : : : : : : : : |
>> 0 +---------------------------------------------------------------------+
>>
>>
>> phoronix-test-suite.glmark2.1024x768.score
>>
>> 70 +----------------------------------------------------------------------+
>> | + + + +..+ + + + + + +.+ |
>> 60 |-: : : : : : : : : : : |
>> | : : : : : : : : : : : |
>> 50 |-:: : :: : : :: : : :: :: : |
>> |: : : : : : : : : : : : : : : : : : : |
>> 40 |:+: : : : : : : : : : : : : : : : : : |
>> |: : : : : : : : : : : : : : : : : : : O |
>> 30 |:+ : : : : : : : : : : : : : : : : : :O O O O |
>> |: : : : : : : : : : : : : : : : : : : |
>> 20 |:+ : : : : : : : : : : : : : : : : : : |
>> | :: : : : : : :: : : :: : : O :: |
>> 10 |-+ : : : : : : : : : : : : : |
>> | : : : O : O : : O : : : O : : : : |
>> 0 +----------------------------------------------------------------------+
>>
>>
>> [*] bisect-good sample
>> [O] bisect-bad sample
>>
> Hmm I must be going blind - there isn't even a single * in either of the graphs.
> Or perhaps my eyesight is fine and the legend or the graphs need fixing.
I cannot make sense of these graphs. The axis' should have descriptive
labels.
Best regards
Thomas
>
> HTH
> -Emil
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-16 14:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 8:32 [PATCH v3 00/15] drm/mgag200: Convert to atomic modesetting Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 01/15] drm/mgag200: Remove HW cursor Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 02/15] drm/mgag200: Clean up mga_set_start_address() Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 03/15] drm/mgag200: Clean up mga_crtc_do_set_base() Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 04/15] drm/mgag200: Move mode-setting code into separate helper function Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 05/15] drm/mgag200: Split MISC register update into PLL selection, SYNC and I/O Thomas Zimmermann
2020-06-03 9:09 ` [drm/mgag200] e44e907dd8: phoronix-test-suite.glmark2.800x600.score -64.9% regression kernel test robot
2020-06-15 20:58 ` Emil Velikov
2020-06-16 3:10 ` Rong Chen
2020-06-16 3:29 ` [LKP] " Rong Chen
2020-06-16 13:49 ` Emil Velikov
2020-06-17 1:35 ` Rong Chen
2020-06-16 13:49 ` Thomas Zimmermann
2020-06-17 1:42 ` Rong Chen
2020-06-16 14:24 ` Thomas Zimmermann [this message]
2020-05-15 8:32 ` [PATCH v3 06/15] drm/mgag200: Update mode registers after plane registers Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 07/15] drm/mgag200: Set pitch in a separate helper function Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 08/15] drm/mgag200: Set primary plane's format in " Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 09/15] drm/mgag200: Move TAGFIFO reset into separate function Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 10/15] drm/mgag200: Move hiprilvl setting into separate functions Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 11/15] drm/mgag200: Move register initialization into separate function Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 12/15] drm/mgag200: Remove out-commented suspend/resume helpers Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 13/15] drm/mgag200: Use simple-display data structures Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 14/15] drm/mgag200: Convert to simple KMS helper Thomas Zimmermann
2020-05-15 8:32 ` [PATCH v3 15/15] drm/mgag200: Replace VRAM helpers with SHMEM helpers Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8345c20c-4794-87d5-4464-c284b8e9cf73@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=emil.velikov@collabora.com \
--cc=john.p.donnelly@oracle.com \
--cc=kraxel@redhat.com \
--cc=lkp@lists.01.org \
--cc=otc.lse.pnp@intel.com \
--cc=rong.a.chen@intel.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).