From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B72CC4345F for ; Sat, 27 Apr 2024 00:18:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B27D1125CB; Sat, 27 Apr 2024 00:18:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=davidwei-uk.20230601.gappssmtp.com header.i=@davidwei-uk.20230601.gappssmtp.com header.b="s4xP+zki"; dkim-atps=neutral Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B5E21125CB for ; Sat, 27 Apr 2024 00:18:01 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1e65b29f703so24998365ad.3 for ; Fri, 26 Apr 2024 17:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=davidwei-uk.20230601.gappssmtp.com; s=20230601; t=1714177080; x=1714781880; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fqmTGkP664boJRzjhc7S0Gtd26iWZty8vGuCMms+S1o=; b=s4xP+zkinGKI6y0n5oxCZ0ALFi1ELZi2bNcb/Dz7cigmmVQ9V0GkfYy8/Xlz9srzWX 6J3+2PZRUuDliExMhjF5aNcQIle68BQ5UOhpAFvYPW2XOAP32k+qi/m2DG+Ag5DrMY3q 010YYua1fWiEJyqcxr189FXNDo/Gfbk9KdM0Rj8oPzN3l0bUt+46d75KN4+zo7b1pRpd EYfBEeG01OkswREND9+4mn+GNy0PZDQGgenfTmgfCBTJzkIge9uFxm6+YXw1qJ9rRvze 7B7MxK6W3HsjORCWvVf6uzu1PCQualodDiM/juJA862w11fYVMMMVM++768rP0ebDkrE 18tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714177080; x=1714781880; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fqmTGkP664boJRzjhc7S0Gtd26iWZty8vGuCMms+S1o=; b=Gn/mzuR7864pKl8snx8NPZYwmN9QjlufDA4xbdk8ouWEiPyZdAjkso3zDYgi2QAvGL D/mKK4CJhJ5BMEh9N5OMVFwDTlC2Yx99H1E2riM4JSBpl/FP1PnzJlEnSGWLRqBawAyn IiWH8qg9+gBG1rv+YSN46f8VlIxfov8R2KU3WwJoEhkeAvO8tnrYRrUeyDmn/L9CLCsS +pODvfy3PKZiqFn/hrquFENyRyel7tk3EGyksxxYErQO+nQB+cZZZQEPx5GkQk3N+vh3 Ie/A+HaFqF2vukM/JkdPc/0UknSijvNc9hpEFV3OJNj4rnOybaLMU8kbfpQYvjP9AkA/ /yYA== X-Forwarded-Encrypted: i=1; AJvYcCVjobsvHvSb7gp3j4iN2HiST0NCWAmpV7kqLIuPJbb7iEe7Zox5a9vJ/yPKE7F2uALGhjaC2qodhbbyq8PByn7MxYVa76hgwJuqWefbfQik X-Gm-Message-State: AOJu0Yz0cWYNO8TLeVwXdx4WrrQn81GlSiwmUFPga4QUesCZZk57s7cB N3rXiROVdRO4oalB4o0FRbEDERy8ZjGAj4FJBKTRmQT50n5Cb0DGXBgqEwhEDFg= X-Google-Smtp-Source: AGHT+IFUGAssCWxanm0G+5JJGXLl3jlzm6HCFUo2+VTIRf+pchJBS1TwIepfoN9/ZtJkA2EtuVR6aQ== X-Received: by 2002:a17:903:8ce:b0:1eb:5682:1ec0 with SMTP id lk14-20020a17090308ce00b001eb56821ec0mr584629plb.45.1714177080246; Fri, 26 Apr 2024 17:18:00 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1256:2:c51:2090:e106:83fa? ([2620:10d:c090:500::4:916b]) by smtp.gmail.com with ESMTPSA id o9-20020a170902778900b001e51b690b7dsm16004827pll.295.2024.04.26.17.17.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 17:17:59 -0700 (PDT) Message-ID: <8357256a-f0e9-4640-8fec-23341fc607db@davidwei.uk> Date: Fri, 26 Apr 2024 17:17:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support Content-Language: en-GB To: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Amritha Nambiar , Maciej Fijalkowski , Alexander Mikhalitsyn , Kaiyuan Zhang , Christian Brauner , Simon Horman , David Howells , Florian Westphal , Yunsheng Lin , Kuniyuki Iwashima , Jens Axboe , Arseniy Krasnov , Aleksander Lobakin , Michael Lass , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Richard Gobert , Sridhar Samudrala , Xuan Zhuo , Johannes Berg , Abel Wu , Breno Leitao , Pavel Begunkov , Jason Gunthorpe , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi , linux-mm@kvack.org, Matthew Wilcox References: <20240403002053.2376017-1-almasrymina@google.com> <20240403002053.2376017-8-almasrymina@google.com> From: David Wei In-Reply-To: <20240403002053.2376017-8-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2024-04-02 5:20 pm, Mina Almasry wrote: > @@ -69,20 +106,26 @@ net_iov_binding(const struct net_iov *niov) > */ > typedef unsigned long __bitwise netmem_ref; > > +static inline bool netmem_is_net_iov(const netmem_ref netmem) > +{ > +#if defined(CONFIG_PAGE_POOL) && defined(CONFIG_DMA_SHARED_BUFFER) I am guessing you added this to try and speed up the fast path? It's overly restrictive for us since we do not need dmabuf necessarily. I spent a bit too much time wondering why things aren't working only to find this :(