dri-devel Archive on lore.kernel.org
 help / color / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org, yamonkar@cadence.com,
	praneeth@ti.com, dri-devel@lists.freedesktop.org,
	peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	laurent.pinchart@ideasonboard.com, sjakhade@cadence.com,
Subject: Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem
Date: Wed, 15 Jan 2020 16:27:01 +0200
Message-ID: <848720ca-6062-8314-e874-3a36f8aee1da@ti.com> (raw)
In-Reply-To: <20200115122253.GA22854@ravnborg.org>

On 15/01/2020 14:22, Sam Ravnborg wrote:
> Hi Jyri.
> On Wed, Jan 15, 2020 at 01:45:38PM +0200, Jyri Sarha wrote:
>> This patch adds a new DRM driver for Texas Instruments DSS IPs used on
>> Texas Instruments Keystone K2G, AM65x, and J721e SoCs. The new DSS IP is
>> a major change to the older DSS IP versions, which are supported by
>> the omapdrm driver. While on higher level the Keystone DSS resembles
>> the older DSS versions, the registers are completely different and the
>> internal pipelines differ a lot.
>> DSS IP found on K2G is an "ultra-light" version, and has only a single
>> plane and a single output. The K3 DSS IPs are found on AM65x and J721E
>> SoCs. AM65x DSS has two video ports, one full video plane, and another
>> "lite" plane without scaling support. J721E has 4 video ports, 2 video
>> planes and 2 lite planes. AM65x DSS has also an integrated OLDI (LVDS)
>> output.
> ...
>> v6: - Check CTM and gamma support from dispc_features when creating crtc
>>     - Implement CTM support for k2g and fix k3 CTM implementation
>>     - Remove gamma property persistence and always write color properties
>>       in a new modeset
> I applied this, just to throw this throgh my build setup.
> checkpatch reported:
> total: 0 errors, 45 warnings, 46 checks, 4920 lines checked
> - space after cast
> - CamelCase
> - Macro argument
> - length warnings
> - alignment
> I would ignore the line length warnings for the coefficients, but fix the
> rest.

You are using --subjective, or are there new warnings turned on since I

Without it I only see long lines warnings and one "break is not useful
after a goto or return" that I had accidentally added there. We have not
cared too much of the long lines, but that is not a big deal, I'll fix them.

I had checked the subjective warnings too, but there I used some
consideration, if the warning would indicate a real problem.

Should I get rid off all the subjective warnings (apart from the long
lines in the coefficients)?

Best regards,

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
dri-devel mailing list

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 11:45 [PATCH v6 0/5] " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 1/5] dt-bindings: display: ti, k2g-dss: Add dt-schema yaml binding Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 2/5] dt-bindings: display: ti, am65x-dss: " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 3/5] dt-bindings: display: ti, j721e-dss: " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2020-01-15 12:22   ` Sam Ravnborg
2020-01-15 14:27     ` Jyri Sarha [this message]
2020-01-15 14:43       ` Sam Ravnborg
2020-01-15 14:58         ` Jyri Sarha
2020-01-15 17:13           ` Sam Ravnborg
2020-01-16 13:16             ` Jyri Sarha
2020-01-15 12:29   ` Sam Ravnborg
2020-01-15 11:45 ` [PATCH v6 5/5] MAINTAINERS: add entry for tidss Jyri Sarha

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=848720ca-6062-8314-e874-3a36f8aee1da@ti.com \
    --to=jsarha@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=maxime@cerno.tech \
    --cc=peter.ujfalusi@ti.com \
    --cc=praneeth@ti.com \
    --cc=sam@ravnborg.org \
    --cc=sjakhade@cadence.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=yamonkar@cadence.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dri-devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dri-devel/0 dri-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dri-devel dri-devel/ https://lore.kernel.org/dri-devel \
	public-inbox-index dri-devel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git