From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: <ogabbay@kernel.org>, <airlied@gmail.com>, <daniel@ffwll.ch>,
<jacek.lawrynowicz@linux.intel.com>,
<stanislaw.gruszka@linux.intel.com>
Cc: dafna@fastmail.com, linux-doc@vger.kernel.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
quic_ajitpals@quicinc.com, quic_pkanojiy@quicinc.com,
quic_carlv@quicinc.com
Subject: Re: [PATCH v4 6/8] accel/qaic: Add mhi_qaic_cntl
Date: Mon, 20 Mar 2023 13:06:17 -0600 [thread overview]
Message-ID: <8571460d-17eb-bc76-6d07-58bd036ff0d0@quicinc.com> (raw)
In-Reply-To: <1679325074-5494-7-git-send-email-quic_jhugo@quicinc.com>
On 3/20/2023 9:11 AM, Jeffrey Hugo wrote:
> From: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
>
> Some of the MHI channels for an AIC100 device need to be routed to
> userspace so that userspace can communicate directly with QSM. The MHI
> bus does not support this, and while the WWAN subsystem does (for the same
> reasons), AIC100 is not a WWAN device. Also, MHI is not something that
> other accelerators are expected to share, thus an accel subsystem function
> that meets this usecase is unlikely.
>
> Create a QAIC specific MHI userspace shim that exposes these channels.
>
> Start with QAIC_SAHARA which is required to boot AIC100 and is consumed by
> the kickstart application as documented in aic100.rst
>
> Each AIC100 instance (currently, up to 16) in a system will create a
> chardev for QAIC_SAHARA. This chardev will be found as
> /dev/<mhi instance>_QAIC_SAHARA
> For example - /dev/mhi0_QAIC_SAHARA
>
> Signed-off-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> ---
> drivers/accel/qaic/mhi_qaic_ctrl.c | 571 +++++++++++++++++++++++++++++++++++++
> drivers/accel/qaic/mhi_qaic_ctrl.h | 12 +
> 2 files changed, 583 insertions(+)
> create mode 100644 drivers/accel/qaic/mhi_qaic_ctrl.c
> create mode 100644 drivers/accel/qaic/mhi_qaic_ctrl.h
>
> diff --git a/drivers/accel/qaic/mhi_qaic_ctrl.c b/drivers/accel/qaic/mhi_qaic_ctrl.c
> new file mode 100644
> index 0000000..a46ba1d
> --- /dev/null
> +++ b/drivers/accel/qaic/mhi_qaic_ctrl.c
> @@ -0,0 +1,571 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/* Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved. */
> +
> +#include <linux/kernel.h>
> +#include <linux/mhi.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/poll.h>
> +#include <linux/version.h>
Will remove this.
Jacek, I think I've got all of your comments addressed. Do you see
anything more? I'm hopeful that we are just looking at one more spin.
-Jeff
next prev parent reply other threads:[~2023-03-20 19:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 15:11 [PATCH v4 0/8] QAIC accel driver Jeffrey Hugo
2023-03-20 15:11 ` [PATCH v4 1/8] accel/qaic: Add documentation for AIC100 accelerator driver Jeffrey Hugo
2023-03-21 13:31 ` Bagas Sanjaya
2023-03-21 21:52 ` Jeffrey Hugo
2023-03-22 4:39 ` Bagas Sanjaya
2023-03-22 15:22 ` Jeffrey Hugo
2023-03-20 15:11 ` [PATCH v4 2/8] accel/qaic: Add uapi and core driver file Jeffrey Hugo
2023-03-21 10:34 ` Oded Gabbay
2023-03-21 15:07 ` Jeffrey Hugo
2023-03-22 8:08 ` Jacek Lawrynowicz
2023-03-20 15:11 ` [PATCH v4 3/8] accel/qaic: Add MHI controller Jeffrey Hugo
2023-03-22 7:51 ` Jacek Lawrynowicz
2023-03-24 10:26 ` Manivannan Sadhasivam
2023-03-24 15:26 ` Jeffrey Hugo
2023-03-27 6:59 ` Manivannan Sadhasivam
2023-03-27 14:34 ` Jeffrey Hugo
2023-03-20 15:11 ` [PATCH v4 4/8] accel/qaic: Add control path Jeffrey Hugo
2023-03-22 7:51 ` Jacek Lawrynowicz
2023-03-20 15:11 ` [PATCH v4 5/8] accel/qaic: Add datapath Jeffrey Hugo
2023-03-22 7:52 ` Jacek Lawrynowicz
2023-03-20 15:11 ` [PATCH v4 6/8] accel/qaic: Add mhi_qaic_cntl Jeffrey Hugo
2023-03-20 18:10 ` kernel test robot
2023-03-20 19:06 ` Jeffrey Hugo [this message]
2023-03-22 8:11 ` Jacek Lawrynowicz
2023-03-22 14:11 ` Jeffrey Hugo
2023-03-20 15:11 ` [PATCH v4 7/8] accel/qaic: Add qaic driver to the build system Jeffrey Hugo
2023-03-21 1:25 ` kernel test robot
2023-03-21 2:27 ` kernel test robot
2023-03-22 8:03 ` Jacek Lawrynowicz
2023-03-22 14:08 ` Jeffrey Hugo
2023-03-20 15:11 ` [PATCH v4 8/8] MAINTAINERS: Add entry for QAIC driver Jeffrey Hugo
2023-03-22 7:49 ` Jacek Lawrynowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8571460d-17eb-bc76-6d07-58bd036ff0d0@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=airlied@gmail.com \
--cc=dafna@fastmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_ajitpals@quicinc.com \
--cc=quic_carlv@quicinc.com \
--cc=quic_pkanojiy@quicinc.com \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).