dri-devel Archive on lore.kernel.org
 help / color / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org, yamonkar@cadence.com,
	praneeth@ti.com, dri-devel@lists.freedesktop.org,
	peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	laurent.pinchart@ideasonboard.com, sjakhade@cadence.com,
	maxime@cerno.tech
Subject: Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem
Date: Thu, 16 Jan 2020 15:16:02 +0200
Message-ID: <8714a7be-ef32-2e46-a736-0433398b15de@ti.com> (raw)
In-Reply-To: <20200115171358.GA23015@ravnborg.org>

On 15/01/2020 19:13, Sam Ravnborg wrote:
> Hi Jyri.
> 
>> Well, I'll bite the bullet then, and start mangling the code to the
>> "strict" format.
> 
> While touching the code please consider moving all logging
> over to the new drm_{err,warn,info,dbg} functions.
> They give the nice "[drm]" marker.
> And they are a tad shorter as you do not have to dereference ddev->dev
> everywhere.
> And you then also gain support for controlling logging using
> drm.debug=0xxxx, os sysfs too.
> 
> See drm_print.h in latest drm_misc_next

After checking out the drm_print.h, I don't think I am willing to do the
switch at least at this time. The drm print functions do not offer much
over the dev_* functions for individual driver debug, and since there is
no 1-to-1 relation from dev_* print functions to drm_* functions I would
have to rethink each print separately. And worst of all the drm prints
do not show in <debugfs>/dynamic_debug/control (requires
CONFIG_DYNAMIC_DEBUG=y).

> 
> With or without this change you can add my:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> 
> 	Sam
> 

Thanks,
Jyri

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 11:45 [PATCH v6 0/5] " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 1/5] dt-bindings: display: ti, k2g-dss: Add dt-schema yaml binding Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 2/5] dt-bindings: display: ti, am65x-dss: " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 3/5] dt-bindings: display: ti, j721e-dss: " Jyri Sarha
2020-01-15 11:45 ` [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem Jyri Sarha
2020-01-15 12:22   ` Sam Ravnborg
2020-01-15 14:27     ` Jyri Sarha
2020-01-15 14:43       ` Sam Ravnborg
2020-01-15 14:58         ` Jyri Sarha
2020-01-15 17:13           ` Sam Ravnborg
2020-01-16 13:16             ` Jyri Sarha [this message]
2020-01-15 12:29   ` Sam Ravnborg
2020-01-15 11:45 ` [PATCH v6 5/5] MAINTAINERS: add entry for tidss Jyri Sarha

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8714a7be-ef32-2e46-a736-0433398b15de@ti.com \
    --to=jsarha@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=maxime@cerno.tech \
    --cc=peter.ujfalusi@ti.com \
    --cc=praneeth@ti.com \
    --cc=sam@ravnborg.org \
    --cc=sjakhade@cadence.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=yamonkar@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dri-devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dri-devel/0 dri-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dri-devel dri-devel/ https://lore.kernel.org/dri-devel \
		dri-devel@lists.freedesktop.org
	public-inbox-index dri-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.dri-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git