From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B9DFC35242 for ; Mon, 27 Jan 2020 09:01:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D112214DB for ; Mon, 27 Jan 2020 09:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D112214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 70E526EA68; Mon, 27 Jan 2020 09:01:56 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19C486EA66; Mon, 27 Jan 2020 09:01:54 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jan 2020 01:01:54 -0800 X-IronPort-AV: E=Sophos;i="5.70,369,1574150400"; d="scan'208";a="221675620" Received: from jpanina-mobl.ger.corp.intel.com (HELO localhost) ([10.252.52.12]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jan 2020 01:01:51 -0800 From: Jani Nikula To: "Bharadiya\,Pankaj" Subject: Re: [[Intel-gfx] [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915 In-Reply-To: <20200127081423.GB8711@plaxmina-desktop.iind.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200115034455.17658-1-pankaj.laxminarayan.bharadiya@intel.com> <878slzea12.fsf@intel.com> <20200123090041.GA804@plaxmina-desktop.iind.intel.com> <87blquik9y.fsf@intel.com> <20200127081423.GB8711@plaxmina-desktop.iind.intel.com> Date: Mon, 27 Jan 2020 11:01:52 +0200 Message-ID: <874kwhclxb.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, sam@ravnborg.org, sudeep.dutt@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 27 Jan 2020, "Bharadiya,Pankaj" wrote: > On Thu, Jan 23, 2020 at 11:39:37AM +0200, Jani Nikula wrote: >> On Thu, 23 Jan 2020, "Bharadiya,Pankaj" wrote: >> > Will rebase remaining patches and submit. >> >> Please also add a patch to convert MISSING_CASE(), > > Will do. > >> and another to remove >> the WARN_ON/WARN_ON_ONCE "overrides" that we have in i915_utils.h. > > Still i915 driver wil have many calls to WARN_ON* after this patch > series gets merged. > > Shall I remove WARN_ON/WARN_ON_ONCE "overrides" so that existing > callers will fallback to original WARN_ON* implementation until > complete conversion is done? Just want to double confirm on this > before I submit a patch. I think when you have most of them converted, we can throw away the "overrides". I'll let you be the judge. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel