dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: "Ruhl, Michael J" <michael.j.ruhl@intel.com>,
	"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
	"joonas.lahtinen@linux.intel.com"
	<joonas.lahtinen@linux.intel.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: Dave Airlie <airlied@redhat.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>, lkp <lkp@intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev
Date: Thu, 29 Apr 2021 21:22:27 +0200	[thread overview]
Message-ID: <87569f49-224e-47ee-27dd-e4ab17eb1e2f@suse.de> (raw)
In-Reply-To: <8f601e6a07dc4fa4aa46577cfcd9c317@intel.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 2320 bytes --]

Hi

Am 29.04.21 um 18:04 schrieb Ruhl, Michael J:
> 
> 
>> -----Original Message-----
>> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
>> Thomas Zimmermann
>> Sent: Thursday, April 29, 2021 6:51 AM
>> To: jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; Vivi, Rodrigo
>> <rodrigo.vivi@intel.com>; airlied@linux.ie; daniel@ffwll.ch; chris@chris-
>> wilson.co.uk
>> Cc: lkp <lkp@intel.com>; intel-gfx@lists.freedesktop.org; dri-
>> devel@lists.freedesktop.org; Thomas Zimmermann
>> <tzimmermann@suse.de>; Dave Airlie <airlied@redhat.com>
>> Subject: [PATCH v8 1/5] drm/ast: Remove reference to struct
>> drm_device.pdev
>>
>> Using struct drm_device.pdev is deprecated. Upcast with to_pci_dev()
>>from struct drm_device.dev to get the PCI device structure.
> 
> Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>

Awesome! Thanks a lot for the timely response. I pushed everything into 
drm-misc-next before the bitrot sets in again.

Best regards
Thomas

> 
> m
> 
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Fixes: ba4e0339a6a3 ("drm/ast: Fixed CVE for DP501")
>> Cc: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
>> Cc: kernel test robot <lkp@intel.com>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Dave Airlie <airlied@redhat.com>
>> Cc: dri-devel@lists.freedesktop.org
>> ---
>> drivers/gpu/drm/ast/ast_main.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_main.c
>> b/drivers/gpu/drm/ast/ast_main.c
>> index 189d783f6e2c..6b49a92dc75f 100644
>> --- a/drivers/gpu/drm/ast/ast_main.c
>> +++ b/drivers/gpu/drm/ast/ast_main.c
>> @@ -411,7 +411,6 @@ struct ast_private *ast_device_create(const struct
>> drm_driver *drv,
>> 		return ast;
>> 	dev = &ast->base;
>>
>> -	dev->pdev = pdev;
>> 	pci_set_drvdata(pdev, dev);
>>
>> 	ast->regs = pcim_iomap(pdev, 1, 0);
>> --
>> 2.31.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-04-29 19:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 10:50 [PATCH v8 0/5] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann
2021-04-29 10:50 ` [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev Thomas Zimmermann
2021-04-29 16:04   ` Ruhl, Michael J
2021-04-29 19:22     ` Thomas Zimmermann [this message]
2021-04-29 10:50 ` [PATCH v8 2/5] drm/i915/gt: " Thomas Zimmermann
2021-04-29 16:02   ` [Intel-gfx] " Ruhl, Michael J
2021-04-29 10:50 ` [PATCH v8 3/5] drm/i915: " Thomas Zimmermann
2021-04-29 16:03   ` Ruhl, Michael J
2021-04-29 10:51 ` [PATCH v8 4/5] drm/i915: Don't assign " Thomas Zimmermann
2021-04-29 10:51 ` [PATCH v8 5/5] drm: Move struct drm_device.pdev to legacy section Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87569f49-224e-47ee-27dd-e4ab17eb1e2f@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=lkp@intel.com \
    --cc=michael.j.ruhl@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --subject='Re: [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).