Re: [Intel-gfx] [CI v2 12/12] drm/edid: add EDID block count and size helpers

From: Jani Nikula <jani.nikula@intel.com>
To: kernel test robot <lkp@intel.com>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [CI v2 12/12] drm/edid: add EDID block count and size helpers
Date: Mon, 11 Apr 2022 16:57:26 +0300	[thread overview]
Message-ID: <875ynfiuyh.fsf@intel.com> (raw)
In-Reply-To: <202204112055.cUmakJdJ-lkp@intel.com>

On Mon, 11 Apr 2022, kernel test robot <lkp@intel.com> wrote:
> Hi Jani,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on drm-tip/drm-tip]
> [also build test WARNING on next-20220411]
> [cannot apply to drm/drm-next drm-intel/for-linux-next v5.18-rc2]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-edid-low-level-EDID-block-read-refactoring-etc/20220411-175027
> base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
> config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220411/202204112055.cUmakJdJ-lkp@intel.com/config)
> compiler: arceb-elf-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/ba74d3cc8cc1b6ba4c34a039e797994ddbc77567
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Jani-Nikula/drm-edid-low-level-EDID-block-read-refactoring-etc/20220411-175027
>         git checkout ba74d3cc8cc1b6ba4c34a039e797994ddbc77567
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/gpu/drm/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>    drivers/gpu/drm/drm_edid.c: In function 'drm_do_get_edid':
>>> drivers/gpu/drm/drm_edid.c:1664:21: warning: array subscript [128, 32640] is outside array bounds of 'struct edid[1]' [-Warray-bounds]
>     1664 |         return block[0];
>          |                ~~~~~^~~
>    drivers/gpu/drm/drm_edid.c:2173:15: note: referencing an object of size 128 allocated by 'krealloc'
>     2173 |         new = krealloc(edid, edid_size(edid), GFP_KERNEL);
>          |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I presume this is caused by the other blunder.

BR,
Jani.

>
>
> vim +1664 drivers/gpu/drm/drm_edid.c
>
> c465bbc87ce372 Stefan Brüns 2014-11-30  1659  
> 4ba0f53ce685b0 Jani Nikula  2022-03-31  1660  static int edid_block_tag(const void *_block)
> 4ba0f53ce685b0 Jani Nikula  2022-03-31  1661  {
> 4ba0f53ce685b0 Jani Nikula  2022-03-31  1662  	const u8 *block = _block;
> 4ba0f53ce685b0 Jani Nikula  2022-03-31  1663  
> 4ba0f53ce685b0 Jani Nikula  2022-03-31 @1664  	return block[0];
> 4ba0f53ce685b0 Jani Nikula  2022-03-31  1665  }
> 4ba0f53ce685b0 Jani Nikula  2022-03-31  1666  

-- 
Jani Nikula, Intel Open Source Graphics Center