From: Jani Nikula <jani.nikula@linux.intel.com>
To: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie>
Subject: Re: [PATCH] drm/i915: Explicit the connector name for DP link training result
Date: Tue, 18 Jul 2017 10:38:00 +0300 [thread overview]
Message-ID: <8760eqb3fr.fsf@intel.com> (raw)
In-Reply-To: <20170717142726.18761-1-paul.kocialkowski@linux.intel.com>
On Mon, 17 Jul 2017, Paul Kocialkowski <paul.kocialkowski@linux.intel.com> wrote:
> This adds the connector name when printing a debug message about the DP
> link training result. It is useful to figure out what connector is
> failing when multiple DP connectors are used.
Perhaps more consistent would be using a prefix like this:
DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n",
connector->base.base.id, connector->base.name);
BR,
Jani.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
> index b79c1c0e404c..75a411c94ce5 100644
> --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> @@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
> if (!intel_dp_link_training_channel_equalization(intel_dp))
> goto failure_handling;
>
> - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d",
> - intel_dp->link_rate, intel_dp->lane_count);
> + DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d for connector %s",
> + intel_dp->link_rate, intel_dp->lane_count,
> + intel_connector->base.name);
> return;
>
> failure_handling:
> - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d",
> - intel_dp->link_rate, intel_dp->lane_count);
> + DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d for connector %s",
> + intel_dp->link_rate, intel_dp->lane_count,
> + intel_connector->base.name);
> if (!intel_dp_get_link_train_fallback_values(intel_dp,
> intel_dp->link_rate,
> intel_dp->lane_count))
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-18 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 14:27 [PATCH] drm/i915: Explicit the connector name for DP link training result Paul Kocialkowski
2017-07-18 7:38 ` Jani Nikula [this message]
2017-07-18 11:28 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760eqb3fr.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.kocialkowski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).