From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [RFC 1/7] drm/gem: Add drm_gem_dumb_map_offset() Date: Fri, 21 Jul 2017 20:41:50 +0200 Message-ID: <8788a365-9805-883b-a94c-9786f1c2f647@tronnes.org> References: <1499867165-60925-1-git-send-email-noralf@tronnes.org> <1499867165-60925-2-git-send-email-noralf@tronnes.org> <87h8y8dtu3.fsf@eliezer.anholt.net> <20170720080049.lzsb4osur7ek6jd2@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE38D6E8C9 for ; Fri, 21 Jul 2017 18:41:53 +0000 (UTC) In-Reply-To: <20170720080049.lzsb4osur7ek6jd2@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CkRlbiAyMC4wNy4yMDE3IDEwLjAwLCBza3JldiBEYW5pZWwgVmV0dGVyOgo+IE9uIFRodSwgSnVs IDIwLCAyMDE3IGF0IDEyOjEzOjA3QU0gKzAyMDAsIE5vcmFsZiBUcsO4bm5lcyB3cm90ZToKPj4g RGVuIDE5LjA3LjIwMTcgMjMuMDEsIHNrcmV2IEVyaWMgQW5ob2x0Ogo+Pj4gTm9yYWxmIFRyw7hu bmVzIDxub3JhbGZAdHJvbm5lcy5vcmc+IHdyaXRlczoKPj4+Cj4+Pj4gQWRkIGEgY29tbW9uIGRy bV9kcml2ZXIuZHVtYl9tYXBfb2Zmc2V0IGZ1bmN0aW9uIGZvciBHRU0gYmFja2VkIGRyaXZlcnMu Cj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVz Lm9yZz4KPj4+IEluc3RlYWQgb2YganVzdCBpbnRyb2R1Y2luZyB0aGUgbmV3IGNvZGUsIGNvdWxk IHdlIHJlcGxhY2UgQ01BJ3MgY29kZQo+Pj4gd2l0aCBjYWxscyB0byB0aGlzIGF0IHRoZSBzYW1l IHRpbWU/Cj4+IEkgaGF2ZSBnb25lIHRocm91Z2ggYWxsIHRoZSBkcm1fZHJpdmVyLT5kdW1iX21h cF9vZmZzZXQKPj4gaW1wbGVtZW50YXRpb25zIGFuZCBmb3VuZCAyMyBkcml2ZXJzIHRoYXQgY291 bGQgdXNlIGl0Ogo+PiAtIDE4IGRyaXZlcnMgdXNlIGRybV9nZW1fY21hX2R1bWJfbWFwX29mZnNl dCgpCj4+IC0gZXh5bm9zX2RybV9nZW1fZHVtYl9tYXBfb2Zmc2V0KCkKPj4gLSBtdGtfZHJtX2dl bV9kdW1iX21hcF9vZmZzZXQoKQo+PiAtIHBzYl9nZW1fZHVtYl9tYXBfZ3R0KCkKPj4gLSByb2Nr Y2hpcF9nZW1fZHVtYl9tYXBfb2Zmc2V0KCkKPj4gLSB0ZWdyYV9ib19kdW1iX21hcF9vZmZzZXQo KQo+Pgo+PiB2Z2VtX2dlbV9kdW1iX21hcCgpIGNhbid0IHVzZSBpdCBiZWNhdXNlIG9mIHRoaXMg Y2hlY2s6Cj4+ICAgICAgaWYgKCFvYmotPmZpbHApIHsKPj4gICAgICAgICAgcmV0ID0gLUVJTlZB TDsKPj4gICAgICAgICAgZ290byB1bnJlZjsKPj4gICAgICB9Cj4+Cj4+IGFybWFkYV9nZW1fZHVt Yl9tYXBfb2Zmc2V0KCkgY2FuJ3QgdXNlIGl0IGJlY2F1c2Ugb2YgdGhpcyBjaGVjazoKPj4gICAg ICAvKiBEb24ndCBhbGxvdyBpbXBvcnRlZCBvYmplY3RzIHRvIGJlIG1hcHBlZCAqLwo+PiAgICAg IGlmIChvYmotPm9iai5pbXBvcnRfYXR0YWNoKSB7Cj4+ICAgICAgICAgIHJldCA9IC1FSU5WQUw7 Cj4+ICAgICAgICAgIGdvdG8gZXJyX3VucmVmOwo+PiAgICAgIH0KPj4KPj4gSSBzZWUgdGhhdCBk cml2ZXJzIG11c3QgaW1wbGVtZW50IGFsbCAzIC5kdW1iXyogY2FsbGJhY2tzOgo+Pgo+PiAgICog VG8gc3VwcG9ydCBkdW1iIG9iamVjdHMgZHJpdmVycyBtdXN0IGltcGxlbWVudCB0aGUKPj4gJmRy bV9kcml2ZXIuZHVtYl9jcmVhdGUsCj4+ICAgKiAmZHJtX2RyaXZlci5kdW1iX2Rlc3Ryb3kgYW5k ICZkcm1fZHJpdmVyLmR1bWJfbWFwX29mZnNldCBvcGVyYXRpb25zLiBTZWUKPj4gICAqIHRoZXJl IGZvciBmdXJ0aGVyIGRldGFpbHMuCj4+Cj4+IEknbSBhIGZhbiBvZiBkZWZhdWx0cywgaXMgdGhl cmUgYW55IHJlYXNvbiB3ZSBjYW4ndCBkbyB0aGlzOgo+IFNvIGluIGdlbmVyYWwgd2UgdHJ5IG5v dCB0byBzZXQgZGVmYXVsdHMgZm9yIHRoZSBtYWluIGRyaXZlciBlbnRyeSBob29rcywKPiB0byBh dm9pZCB0aGUgaGVscGVyIGZ1bmN0aW9ucyBsZWFraW5nIGludG8gY29yZSBhbmQgYmVjb21pbmcg bWFuZGF0b3J5Lgo+IFNvIGUuZy4gLT5hdG9taWNfY29tbWl0IHNob3VsZCBuZXZlciBoYXZlIGEg ZGVmYXVsdCBvZgo+IGRybV9hdG9taWNfaGVscGVyX2NvbW1pdC4KPgo+IFNhbWUgdGhvdWdodCBh cHBsaWVkIGhlcmUgZm9yIHRoZSBkdW1iIGJ1ZmZlcnMgLSB0aGUgaWRlYSBpcyB0aGF0IGRyaXZl cnMKPiB1c2luZyBhbnkga2luZCBvZiBidWZmZXIgbWFuYWdlciBzY2hlbWUgY291bGQgaGF2ZSBk dW1iIGJ1ZmZlcnMsIGluY2x1ZGluZwo+IG1heWJlIG5vdCBoYXZpbmcgYSBidWZmZXIgbWFuYWdl ciBhdCBhbGwgKGFuZCB5b3UgZ2V0IHNvbWUgY29va2llIHRvCj4gZGlyZWN0IHZyYW0gYWxsb2Nh dGlvbnMgb3Igd2hhdGV2ZXIpLiBCdXQgZXZlcnlvbmUgZW5kZWQgdXAgd2l0aCBnZW0sIGp1c3QK PiB3aXRoIGRpZmZlcmVudCBraW5kcyBvZiBiYWNraW5nIHN0b3JhZ2UgaW1wbGVtZW50YXRpb25z IChjbWEsIHNobWVtIG9yCj4gdHRtKS4KPgo+IEkgdGhpbmsgaXQgbWFrZXMgc2Vuc2UgdG8gbWFr ZSB0aGVzZSB0aGUgZGVmYXVsdHMgYW5kIHJpcCBvdXQgdGhlIGRlZmF1bHQKPiBhc3NpZ25tZW50 IGZyb20gYWxsIGRyaXZlcnMuCj4+ICAgaW50IGRybV9tb2RlX21tYXBfZHVtYl9pb2N0bChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgICAgICAgICAgICAgICAgICAgdm9pZCAqZGF0YSwgc3Ry dWN0IGRybV9maWxlICpmaWxlX3ByaXYpCj4+ICAgewo+PiAgICAgICBzdHJ1Y3QgZHJtX21vZGVf bWFwX2R1bWIgKmFyZ3MgPSBkYXRhOwo+Pgo+PiAgICAgICAvKiBjYWxsIGRyaXZlciBpb2N0bCB0 byBnZXQgbW1hcCBvZmZzZXQgKi8KPj4gLSAgICAgaWYgKCFkZXYtPmRyaXZlci0+ZHVtYl9tYXBf b2Zmc2V0KQo+PiArICAgIGlmICghZGV2LT5kcml2ZXItPmR1bWJfY3JlYXRlKQo+PiAgICAgICAg ICByZXR1cm4gLUVOT1NZUzsKPj4KPj4gLSAgICAgcmV0dXJuIGRldi0+ZHJpdmVyLT5kdW1iX21h cF9vZmZzZXQoZmlsZV9wcml2LCBkZXYsIGFyZ3MtPmhhbmRsZSwKPj4gJmFyZ3MtPm9mZnNldCk7 Cj4+ICsgICAgIGlmIChkZXYtPmRyaXZlci0+ZHVtYl9tYXBfb2Zmc2V0KQo+PiArICAgICAgICBy ZXR1cm4gZGV2LT5kcml2ZXItPmR1bWJfbWFwX29mZnNldChmaWxlX3ByaXYsIGRldiwgYXJncy0+ aGFuZGxlLAo+PiAmYXJncy0+b2Zmc2V0KTsKPj4gKyAgICBlbHNlCj4+ICsgICAgICAgIHJldHVy biBkcm1fZ2VtX2R1bWJfbWFwX29mZnNldChmaWxlX3ByaXYsIGRldiwgYXJncy0+aGFuZGxlLAo+ PiAmYXJncy0+b2Zmc2V0KTsKPj4gICB9Cj4+Cj4+ICAgaW50IGRybV9tb2RlX2Rlc3Ryb3lfZHVt Yl9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgICAgICAgICAgICAgICAgICB2b2lk ICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdikKPj4gICB7Cj4+ICAgICAgIHN0cnVj dCBkcm1fbW9kZV9kZXN0cm95X2R1bWIgKmFyZ3MgPSBkYXRhOwo+Pgo+PiAtICAgICBpZiAoIWRl di0+ZHJpdmVyLT5kdW1iX2Rlc3Ryb3kpCj4+ICsgICAgaWYgKCFkZXYtPmRyaXZlci0+ZHVtYl9j cmVhdGUpCj4+ICAgICAgICAgICByZXR1cm4gLUVOT1NZUzsKPj4KPj4gLSAgICByZXR1cm4gZGV2 LT5kcml2ZXItPmR1bWJfZGVzdHJveShmaWxlX3ByaXYsIGRldiwgYXJncy0+aGFuZGxlKTsKPj4g KyAgICAgaWYgKGRldi0+ZHJpdmVyLT5kdW1iX2Rlc3Ryb3kpCj4+ICsgICAgICAgIHJldHVybiBk ZXYtPmRyaXZlci0+ZHVtYl9kZXN0cm95KGZpbGVfcHJpdiwgZGV2LCBhcmdzLT5oYW5kbGUpOwo+ PiArICAgIGVsc2UKPj4gKyAgICAgICAgcmV0dXJuIGRybV9nZW1fZHVtYl9kZXN0cm95KGZpbGVf cHJpdiwgZGV2LCBhcmdzLT5oYW5kbGUpOwo+PiAgIH0KPj4KPj4gVGhlcmUgYXJlIDM2IGRyaXZl cnMgdGhhdCB1c2UgZHJtX2dlbV9kdW1iX2Rlc3Ryb3koKSBkaXJlY3RseS4KPj4gdmdlbSB2aW9s YXRlcyB0aGUgZG9jcyBhbmQgZG9lc24ndCBzZXQgLmR1bWJfZGVzdHJveS4KPiBJbnRlcmVzdGlu Zywgc3VwcmlzaW5nIGl0IGRvZXNuJ3QgbGVhayBsaWtlIG1hZC4KPiAgIAo+Pj4gSSBzdXNwZWN0 IHRoYXQgaWYgd2UgaGFkIENNQSBzdWJjbGFzcyBmcm9tIGRybV9mYl9nZW0gKG9yIHdlIG1vdmUg dGhlCj4+PiBnZW0gb2JqZWN0cyB0byB0aGUgYmFzZSBjbGFzcyksIHdlIGNvdWxkIHJlbW92ZSBh IGxvdCBvZiBpdHMgY29kZSB0aGF0Cj4+PiB5b3UncmUgY29weWluZyBpbiBwYXRjaCAyLCBhcyB3 ZWxsLgo+PiBZZXMsIHRoYXQgd2FzIHRoZSBpbnRlbnRpb24uCj4gSSBndWVzcyB3ZSdkIG5lZWQg dG8gc2VlIG1vcmUgb2YgdGhlIGdyYW5kIHBsYW4gLi4uCgpDdXJyZW50bHkgaXQgbG9va3MgbGlr ZSA0IHBhdGNoc2V0czoKCjEuIEFkZCBkcm1fZ2VtX2R1bWJfbWFwX29mZnNldCgpIGFuZCBpbXBs ZW1lbnQgZGVmYXVsdHMgYXMgZGlzY3Vzc2VkIGFib3ZlLgoKMi4gQWRkIGRybV9nZW1fb2JqZWN0 IHBvaW50ZXJzIHRvIGRybV9mcmFtZWJ1ZmZlciBhbmQgY3JlYXRlIG1hdGNoaW5nCiAgICBoZWxw ZXJzIGZvcjoKICAgICAgZHJtX2ZyYW1lYnVmZmVyX2Z1bmNzLT5jcmVhdGVfaGFuZGxlCiAgICAg IGRybV9mcmFtZWJ1ZmZlcl9mdW5jcy0+ZGVzdHJveQogICAgICBkcm1fbW9kZV9jb25maWdfZnVu Y3MtPmZiX2NyZWF0ZQogICAgICBTaG91bGQgSSBwdXQgdGhlIGZ1bmN0aW9ucyBpbiBkcm1fZnJh bWVidWZmZXJfaGVscGVyLltoLGNdID8KICAgIFVzZSB0aGVzZSBoZWxwZXJzIGluIHRoZSBjbWEg bGlicmFyeQoKMy4gQWRkIGRybV9mYl9oZWxwZXJfc2ltcGxlX2luaXQoKSBhbmQgZHJtX2ZiX2hl bHBlcl9zaW1wbGVfZmluaSgpCiAgICBVc2UgdGhlbSBpbiBkcml2ZXJzIHdoZXJlIGFwcGxpY2Fi bGUuCgo0LiBBZGQgc2htZW0gbGlicmFyeQogICAgQ29udmVydCB0aW55ZHJtIHRvIHNobWVtLgoK Tm9yYWxmLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==