From: Eric Anholt <eric@anholt.net>
To: Rob Herring <robh@kernel.org>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v8] drm: Add library for shmem backed GEM objects
Date: Wed, 13 Mar 2019 13:56:36 -0700 [thread overview]
Message-ID: <87bm2etrwb.fsf@anholt.net> (raw)
In-Reply-To: <20190313004344.24169-1-robh@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 705 bytes --]
Rob Herring <robh@kernel.org> writes:
> From: Noralf Trønnes <noralf@tronnes.org>
>
> This adds a library for shmem backed GEM objects.
I read through the whole thing, and the only bit I didn't like
(drm_gem_shmem_create_with_handle returns an unrefcounted object
pointer) was a copy-and-paste from CMA that we should fix in both
places, and has no downside in the current usage since the pointer value
is unused. Just one question left:
> v7:
> - Use write-combine for mmap instead. This is the more common
> case. (robher)
I don't actually see this in the code. Wasn't there supposed to be a:
vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags));
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-13 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 0:43 [PATCH v8] drm: Add library for shmem backed GEM objects Rob Herring
2019-03-13 20:56 ` Eric Anholt [this message]
2019-03-14 16:50 ` Rob Herring
2019-03-14 19:06 ` anholt
2019-03-14 16:34 ` [PATCH] drm/v3d: Use the new shmem helpers to reduce driver boilerplate Eric Anholt
2019-03-14 16:47 ` Eric Anholt
2019-03-14 18:15 ` Rob Herring
2019-03-14 19:11 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm2etrwb.fsf@anholt.net \
--to=eric@anholt.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).