From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69EBC43460 for ; Thu, 1 Apr 2021 13:31:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95ED661247 for ; Thu, 1 Apr 2021 13:31:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95ED661247 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EFE316ECB9; Thu, 1 Apr 2021 13:31:30 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A6EA6ECB0; Thu, 1 Apr 2021 13:31:29 +0000 (UTC) IronPort-SDR: 5hxlm0ERz18lzngg6fT/IkiycJ1YVYCER5gossB56vNWOv5i1BRvTOCxiZsZB4uyrzIIyxnzQ2 Uwb+mCL4282A== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="212498821" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="212498821" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 06:31:27 -0700 IronPort-SDR: 5tvB92jiRMGNLabXybckCSLFFBmaAQU7vUD+qPiiyyb+IZu2wKXYLWG2p2afaEIA03ZnIMWo2v zWr4SP+SYDZg== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="419204532" Received: from shergane-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.188]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 06:31:08 -0700 From: Jani Nikula To: Lyude Paul , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux In-Reply-To: <20210326203807.105754-6-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210326203807.105754-1-lyude@redhat.com> <20210326203807.105754-6-lyude@redhat.com> Date: Thu, 01 Apr 2021 16:31:05 +0300 Message-ID: <87eefum8rq.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Guido =?utf-8?Q?G=C3=BCnther?= , Oleg Vasilev , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Sam Ravnborg , Marek Szyprowski , Tomi Valkeinen , Rodrigo Siqueira , Michal Simek , Jonathan Hunter , Vasily Khoruzhick , "Jerry \(Fangzhi\) Zuo" , Luben Tuikov , Ben Skeggs , Swapnil Jakhade , "moderated list:ARM/ZYNQ ARCHITECTURE" , Jonas Karlman , Leo Li , Lucas De Marchi , Joe Perches , Yuti Amonkar , Jyri Sarha , Rodrigo Vivi , "open list:DRM DRIVERS FOR NVIDIA TEGRA" , Mikita Lipski , Sean Paul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Jernej Skrabec , Chris Park , Eryk Brol , Hyun Kwon , open list , Robert Foss , Julia Lawall , Boris Brezillon , Thomas Zimmermann , Alex Deucher , Andy Yan , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Christian =?utf-8?Q?K=C3=B6n?= =?utf-8?Q?ig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 26 Mar 2021, Lyude Paul wrote: > * The @dev field should be set to a pointer to the device that implements the > - * AUX channel. > + * AUX channel. As well, the @drm_dev field should be set to the &drm_device > + * that will be using this AUX channel as early as possible. For many graphics > + * drivers this should happen before drm_dp_aux_init(), however it's perfectly > + * fine to set this field later so long as it's assigned before calling > + * drm_dp_aux_register(). Perhaps add a follow-up patch to actually ensure this is the case in drm_dp_aux_register()? > * > * The @name field may be used to specify the name of the I2C adapter. If set to > * %NULL, dev_name() of @dev will be used. > @@ -1877,6 +1883,7 @@ struct drm_dp_aux { > const char *name; > struct i2c_adapter ddc; > struct device *dev; > + struct drm_device *drm_dev; Bikeshed, I would probably have called it just drm for brevity, but no strong feelings. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel