From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/v3d: fix a NULL vs error pointer mixup Date: Fri, 22 Mar 2019 14:30:07 -0700 Message-ID: <87ftre38dc.fsf@anholt.net> References: <20190321062731.GC21489@kadam> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0910236584==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B4C06E3C9 for ; Fri, 22 Mar 2019 21:30:09 +0000 (UTC) In-Reply-To: <20190321062731.GC21489@kadam> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0910236584== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Dan Carpenter writes: > The drm_gem_shmem_create() returns error pointers and v3d_bo_create() is > also supposed to return error pointers. > > Fixes: 40609d4820b2 ("drm/v3d: Use the new shmem helpers to reduce driver boilerplate.") > Signed-off-by: Dan Carpenter Sigh, error pointers are the worst. Reviewed, and applying to drm-misc-next. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyVU98ACgkQtdYpNtH8 nugzshAArfO6xZd+OAAq2ENQfssmNZK7k2Q/SovgJAPCTQrgfbngXVTosloyAsVD voiI8Y2E11iLv8qk7XVCYn42HScObPJ+a90an7+fG7DFmiz+d2j+o34ZhUhHqEB1 B7XXIsdnYdydKYHW1USna7fXKXxLE0qp8T6AUnzEojNfgxiUCmTmEvu5OcN6xDzw /DS5MSe+Ns4OvlN6JJvUehuvmY9NHGgVOCT2CVvYOxtNKSySYOlyDm59qXcLcef6 O8ndNBOP6pIeNuh7k1bmPZAuSAgwf9c9ltChqmGr3DKa3HUMn6NgkTCoUXTy6qT8 /Jz1tbo/zJWto0uEieXZEm6hEcxgMelRwStpx0MQ/xAoW+8RpZAc9Oxp2/pt99Ko 6/J3olHqDch/vhMAVLliPuH8LaYmFK4j1HgrOy1IhgNC6r50Gp7h310tLr9/3jjQ sRc8fg3JLw8iBB3atYqysE+1Nwag3NhXwek6+6fF+7LXhHJo0DAKMTf7VchtPVgw 9oag5UjqarMuiiih7KbLdH2sc7Jk58A+tfa5IQyjAhNhbfO0s5IDEytMqN4Vv1yi HLkQPdwza7Xe0CJAFSDowSO/F5r41OgbV4ygk7+xC1hQ9Bf63mjCJop0LVEiStv3 XPiCc82k2OXe8tdM9fsGXKvro+HskOAnILrReEdy4RUVE8iHfKE= =224e -----END PGP SIGNATURE----- --=-=-=-- --===============0910236584== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0910236584==--