From: Eric Anholt <eric@anholt.net>
To: "Noralf Trønnes" <noralf@tronnes.org>, dri-devel@lists.freedesktop.org
Subject: Re: [RFC 2/7] drm: Add GEM backed framebuffer library
Date: Wed, 19 Jul 2017 13:59:34 -0700 [thread overview]
Message-ID: <87k234dtxl.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <84ead3e1-146a-d69c-2280-061a5d36f6ba@tronnes.org>
[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]
Noralf Trønnes <noralf@tronnes.org> writes:
> Den 12.07.2017 15.46, skrev Noralf Trønnes:
>> Add a library for drivers that can use a simple representation
>> of a GEM backed framebuffer.
>>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>> ---
>
> This patch adds a gem backed drm_framebuffer like this:
>
> struct drm_fb_gem {
> /**
> * @base: Base DRM framebuffer
> */
> struct drm_framebuffer base;
> /**
> * @obj: GEM object array backing the framebuffer. One object per
> * plane.
> */
> struct drm_gem_object *obj[4];
> };
>
> Now I wonder if it would be better to extend drm_framebuffer instead:
>
> struct drm_framebuffer {
> + /**
> + * @obj: GEM objects backing the framebuffer, one per plane (optional).
> + */
> + struct drm_gem_object *obj[4];
> };
FWIW, I would love to see this tried. I think we would end up with some
nice cleanups if we did so.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-07-19 20:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 13:45 [RFC 0/7] drm: Add shmem GEM library Noralf Trønnes
2017-07-12 13:45 ` [RFC 1/7] drm/gem: Add drm_gem_dumb_map_offset() Noralf Trønnes
2017-07-18 21:06 ` Noralf Trønnes
2017-07-20 8:04 ` Daniel Vetter
2017-07-19 21:01 ` Eric Anholt
2017-07-19 22:13 ` Noralf Trønnes
2017-07-20 8:00 ` Daniel Vetter
2017-07-21 18:41 ` Noralf Trønnes
2017-07-24 8:28 ` Daniel Vetter
2017-07-24 19:41 ` Noralf Trønnes
2017-07-12 13:46 ` [RFC 2/7] drm: Add GEM backed framebuffer library Noralf Trønnes
2017-07-18 15:42 ` Noralf Trønnes
2017-07-19 20:59 ` Eric Anholt [this message]
2017-07-20 8:10 ` Daniel Vetter
2017-07-21 18:39 ` Noralf Trønnes
2017-07-25 7:00 ` Daniel Vetter
2017-07-12 13:46 ` [RFC 3/7] drm/fb-helper: Support shadow buffer with deferred io Noralf Trønnes
2017-07-12 13:46 ` [RFC 4/7] drm/fb-helper: Add simple init/fini functions Noralf Trønnes
2017-07-12 13:46 ` [RFC 5/7] drm: Add library for shmem backed GEM objects Noralf Trønnes
2017-07-12 13:46 ` [RFC 6/7] drm: Add kms library for shmem backed GEM Noralf Trønnes
2017-07-12 13:46 ` [RFC 7/7] drm/tinydrm: Switch from CMA to shmem buffers Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k234dtxl.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).