From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 1/3] drm/mxsfb: Use gem_free_object_unlocked
Date: Mon, 17 Jul 2017 11:01:33 -0700
Message-ID: <87k237c58i.fsf@eliezer.anholt.net>
References: <20170717151045.4188-1-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2139430478=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from anholt.net (anholt.net [50.246.234.109])
 by gabe.freedesktop.org (Postfix) with ESMTP id 01B2C6E264
 for <dri-devel@lists.freedesktop.org>; Mon, 17 Jul 2017 18:11:21 +0000 (UTC)
In-Reply-To: <20170717151045.4188-1-daniel.vetter@ffwll.ch>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Marek Vasut <marex@denx.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, Daniel Vetter <daniel.vetter@intel.com>
List-Id: dri-devel@lists.freedesktop.org

--===============2139430478==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> CMA helpers are struct_mutex free, and so is the mxsfb itself. And
> that's the only valid reason for using gem_free_object. Please read
> the kerneldoc for this stuff :-)

I'm sure all of these came from copy and paste, not the docs.  That
said, the CMA docs currently say:

     * Drivers using the CMA helpers should set this as their
     * &drm_driver.gem_free_object callback.

If you drop the complaint about us reading the docs, the series is:

Reviewed-by: Eric Anholt <eric@anholt.net>

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlls+30ACgkQtdYpNtH8
nuis3RAAsq6MmIQSjm2r1bVYw5h8vxffugR4HBK5jOnbbU3jJdg8uz7flf2qJxf/
opKdvKgvByGw5Mz/jQf7B4q+PMNZM6o2K0JPlD/X7NFvZJYV2JB4CaSwat5cK4i8
mZO+LRX2RPJqulW7bK4Hg4lmG8cxIlW9mC5Ng4qSAz1tMwaiwRXhR2lUIh+xaSuW
u0uagxon3rKzzjkGvyIs2ehhxYPIu/v3Fv3DVduyeVOA6chaVMFDjOsdMHoVq1bA
HV9Rg0BD8+l0sr8xZI10zGOaV7l29E8P0lwFTA9wACH9NDxv7f/707CCLRO3pi1q
2LKlassKlm7X6ngixPzrjychMo2xgc0k3ZOzGZ9m5aLxjabYsMbQoVOckS+tgeDy
rHnGAPeyZW/0MCQeNcdlmj1NwVCi/wCqWTh/PhR7cGLhjvxNCWy1+1we6hXId/XH
b16CW0v+pGl8Bt9XUjeMSpoFas19y9UxJOqvBAFkrYlpVHtU3j3ydIb5s7gAy0uF
JsHQ9i9NRSDYkAtaGpLEsBmo2XrpT7JLi8F+n1U67PJIxUyD+G/rasysdZxFb8rV
GD3EGmsgfxyO7dOvFgwVwOF4VyjnQWmt2KHszNm3y+PgxT5mQvG+Nzcw3IrcXfyM
pwU34e8DM9k/6kNwOzPIkcvjhUM5ub1ZFIvJoANbVm5fc/d16sA=
=LYXI
-----END PGP SIGNATURE-----
--=-=-=--

--===============2139430478==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============2139430478==--