From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31350C2D0E7 for ; Wed, 25 Mar 2020 18:20:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 170BD206F8 for ; Wed, 25 Mar 2020 18:20:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 170BD206F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 557AD6E817; Wed, 25 Mar 2020 18:20:49 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5C736E1D8; Wed, 25 Mar 2020 18:20:47 +0000 (UTC) IronPort-SDR: x1e3gsmSYJHZTKaqSg4d9Ot9jvzsAHHPsTBPuJrtz2Hv2t1t2CiMjGMvNPdAPWh3gaNAgeazCc U3jCUgHM8svA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2020 11:20:47 -0700 IronPort-SDR: Qq+zrMg+AgOBQf3wjCvW9zqjBhg9vKkLE4Tm2d8ABIPecQfVtooWdr9oHg0guRmlVWYlULGPdZ Vy9JqJqwS0Sw== X-IronPort-AV: E=Sophos;i="5.72,305,1580803200"; d="scan'208";a="393709857" Received: from yrahamim-mobl.ger.corp.intel.com (HELO localhost) ([10.255.194.58]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2020 11:20:42 -0700 From: Jani Nikula To: Daniel Vetter , DRI Development Subject: Re: [Intel-gfx] [PATCH 02/51] drm/i915: Don't clear drvdata in ->release In-Reply-To: <20200323144950.3018436-3-daniel.vetter@ffwll.ch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200323144950.3018436-1-daniel.vetter@ffwll.ch> <20200323144950.3018436-3-daniel.vetter@ffwll.ch> Date: Wed, 25 Mar 2020 20:20:38 +0200 Message-ID: <87o8ski9e1.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Greg Kroah-Hartman , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 23 Mar 2020, Daniel Vetter wrote: > For two reasons: > > - The driver core clears this already for us after we're unloaded in > __device_release_driver(). > > - It's way too late, the drm_device ->release callback might massively > outlive the underlying physical device, since a drm_device can't be *can be*? > kept alive by open drm_file or well really anything else userspace > is still hanging onto. So if we clear this ourselves, we should > clear it in the pci ->remove callback, not in the drm_device > ->relase callback. ->release Reviewed-by: Jani Nikula > > Looking at git history this was fixed in the driver core with > > commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > Author: Hans de Goede > Date: Wed May 23 00:09:34 2012 +0200 > > device-core: Ensure drvdata = NULL when no driver is bound > > v2: Cite the core fix in the commit message (Chris). > > Cc: Greg Kroah-Hartman > Cc: Chris Wilson > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_drv.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 48ba37e35bea..4792051e9e2e 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -909,9 +909,6 @@ static void i915_driver_destroy(struct drm_i915_private *i915) > > drm_dev_fini(&i915->drm); > kfree(i915); > - > - /* And make sure we never chase our dangling pointer from pci_dev */ > - pci_set_drvdata(pdev, NULL); > } > > /** -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel