From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 22/25] drm: no-op out GET_STATS ioctl Date: Thu, 08 Aug 2013 17:55:45 +0200 Message-ID: <87pptomb26.fsf@yvain.anholt.net> References: <1375969295-18929-1-git-send-email-daniel.vetter@ffwll.ch> <1375969295-18929-23-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0999626347==" Return-path: Received: from anholt.net (unknown [63.227.213.248]) by gabe.freedesktop.org (Postfix) with ESMTP id 872BBE7684 for ; Thu, 8 Aug 2013 09:03:38 -0700 (PDT) In-Reply-To: <1375969295-18929-23-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: DRI Development Cc: Daniel Vetter List-Id: dri-devel@lists.freedesktop.org --===============0999626347== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Daniel Vetter writes: > Again only used by a tests in libdrm and by dristat. Nowadays we have > much better tracing tools to get detailed insights into what a drm > driver is doing. And for a simple "does it work" kind of question that > these stats could answer we have plenty of dmesg debug log spew. > > So I don't see any use for this stat gathering complexity at all. > > To be able to gradually drop things start with ripping out the > interfaces to it, here the ioctl. > > To prevent dristat from eating its own stack garbage we can't use the > drm_noop ioctl though, since we need to clear the return data with a > memset. I'm happy to see these two die. Even back in the day we didn't use them. This has been quite a trip down memory lane. Patch 9 typo: s/functinal/functional/ Patch 25 typo: s/loose/lose/ Patches 2, 6-11, 19, 21, 22, 24, 25 are: Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBCAAGBQJSA7+BAAoJELXWKTbR/J7odD4P/A8AUvflJRLaXszDAxBczsF2 pylOUDE4S33imIOLxc70rLg2bhkI3aEBOp0AY6rYPVLuZ83fcqWqzMfvl3kv4Gcf KW6jbQgyvkVxtE4+Tohm6m4vaufIfzb0fMOdfzhaQRz1+LEs56XkTpY6qscDQO14 hZU29f7B+hkVRAWLSrR1FW6/VxXy3YsX8eKZfLggSz0HVtIEDYpeKCm2pLRZIwEi ji86YGBkHo9oOg4fxvn9L+3Sfi/J0hVN/FvX1RvkaZ+kAgo7UYlC8nVD+5AMlyln 5hU+yW5X0OmfcQuNJ1VckpGM/QyAH7SN8p4+pufjkFe40rjL1oQfHH+FYdEnP0Jo JpgqC3qsdOe1Wk9AiAydY7Y2RI8GBVfTjsDMnhjd04zVZnOBHoFy0zRfEcTeLWA4 2hMZtollh9Dt1FTnYpJ33EElTfE+7qE3c6JCOZhMV241vbbFk4gQyzmDaZCh01dT YCT52aPVmct8ZPahW6oE+plX4a/0gP9TA/CM49pbUE1gcl29jarYnQ0OYbMgEZRo V0dn9icw03VrHPfGpL/33jT0aOAAmpP6FSiMxxk/ZVl/UkEPsMIBHv/p9csiWa3N z71jw/HfPpTzuQp2glIywWtf7WnrlQoL4bU2Ct/jPCiyM6FrG+V2MKffibjE/JkP /1or9wFx+V+nFJ46j9NE =6klO -----END PGP SIGNATURE----- --=-=-=-- --===============0999626347== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0999626347==--