From: Jani Nikula <jani.nikula@linux.intel.com>
To: Wambui Karuga <wambui.karugax@gmail.com>,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
airlied@linux.ie, daniel@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org, sean@poorly.run,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 11/12] drm/i915/hdmi: convert to struct drm_device based logging macros.
Date: Tue, 11 Feb 2020 15:47:33 +0200 [thread overview]
Message-ID: <87tv3xz156.fsf@intel.com> (raw)
In-Reply-To: <20200206080014.13759-12-wambui.karugax@gmail.com>
On Thu, 06 Feb 2020, Wambui Karuga <wambui.karugax@gmail.com> wrote:
> @@ -1364,11 +1372,15 @@ int intel_hdmi_hdcp_write_an_aksv(struct intel_digital_port *intel_dig_port,
> static int intel_hdmi_hdcp_read_bksv(struct intel_digital_port *intel_dig_port,
> u8 *bksv)
> {
> + struct drm_i915_private *i915 =
> + intel_dig_port->base.base.dev->dev_private;
The preferred way to get from intel_digital_port to i915 throughout is
struct drm_i915_private *i915 = to_i915(intel_dig_port->base.base.dev);
I realize there are some bad examples in the file; I've posted [1] to
fix them.
BR,
Jani.
[1] http://patchwork.freedesktop.org/patch/msgid/20200211134427.31605-1-jani.nikula@intel.com
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-11 13:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 8:00 [PATCH v2 00/12] drm/i915/display: convert to drm_device based logging macros Wambui Karuga
2020-02-06 8:00 ` [PATCH v2 01/12] drm/i915/dp: convert to struct " Wambui Karuga
2020-02-11 14:03 ` Jani Nikula
2020-02-06 8:00 ` [PATCH v2 02/12] drm/i915/dp_link_training: convert to " Wambui Karuga
2020-02-06 8:00 ` [PATCH v2 03/12] drm/i915/atomic: conversion " Wambui Karuga
2020-02-06 8:00 ` [PATCH v2 04/12] drm/i915/color: " Wambui Karuga
2020-02-06 8:00 ` [PATCH v2 05/12] drm/i915/crt: automatic " Wambui Karuga
2020-02-06 8:00 ` [PATCH v2 06/12] drm/i915/dp_aux_backlight: convert " Wambui Karuga
2020-02-11 14:08 ` Jani Nikula
2020-02-06 8:00 ` [PATCH v2 07/12] drm/i915/dpll_mgr: " Wambui Karuga
2020-02-06 8:00 ` [PATCH v2 08/12] drm/i915/combo_phy: convert to struct drm_device " Wambui Karuga
2020-02-06 8:00 ` [PATCH v2 09/12] drm/i915/dp_mst: convert to drm_device based " Wambui Karuga
2020-02-11 14:05 ` Jani Nikula
2020-02-06 8:00 ` [PATCH v2 10/12] drm/i915/dsi_vbt: " Wambui Karuga
2020-02-06 8:00 ` [PATCH v2 11/12] drm/i915/hdmi: convert to struct " Wambui Karuga
2020-02-11 13:47 ` Jani Nikula [this message]
2020-02-06 8:00 ` [PATCH v2 12/12] drm/i915/dpio_phy: convert to " Wambui Karuga
2020-02-11 14:09 ` [PATCH v2 00/12] drm/i915/display: " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv3xz156.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).