From: Javier Martinez Canillas <javierm@redhat.com>
To: Jocelyn Falempe <jfalempe@redhat.com>, linux-kernel@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
dri-devel@lists.freedesktop.org,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable
Date: Fri, 27 Oct 2023 11:31:45 +0200 [thread overview]
Message-ID: <87v8aso1ha.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <b048247c-75e9-488e-a4f3-b227a38bca5e@redhat.com>
Jocelyn Falempe <jfalempe@redhat.com> writes:
> Hi,
>
> On 21/10/2023 00:52, Javier Martinez Canillas wrote:
>> Avoid a possible uninitialized use of the crtc_state variable in function
>> ssd132x_primary_plane_atomic_check() and avoid the following Smatch warn:
>>
>> drivers/gpu/drm/solomon/ssd130x.c:921 ssd132x_primary_plane_atomic_check()
>> error: uninitialized symbol 'crtc_state'.
>
> That looks trivial, so you can add:
>
> Acked-by: Jocelyn Falempe <jfalempe@redhat.com>
>
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-10-27 9:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 22:52 [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable Javier Martinez Canillas
2023-10-27 8:21 ` Jocelyn Falempe
2023-10-27 9:31 ` Javier Martinez Canillas [this message]
2023-10-31 9:56 ` Geert Uytterhoeven
2023-10-31 10:11 ` Javier Martinez Canillas
2023-10-31 10:31 ` Geert Uytterhoeven
2023-10-31 11:27 ` Javier Martinez Canillas
2023-10-31 11:53 ` Maxime Ripard
2023-10-31 13:00 ` Geert Uytterhoeven
2023-10-31 13:52 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8aso1ha.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jfalempe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).