From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 574CFC48BDF for ; Tue, 15 Jun 2021 14:03:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DFC161459 for ; Tue, 15 Jun 2021 14:03:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DFC161459 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BB1488AD9; Tue, 15 Jun 2021 14:03:47 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0331988AD9 for ; Tue, 15 Jun 2021 14:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623765825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kLMUNwIYFZdrtc2NmHvIqgVHyZsoQim6Z5rwLBywteg=; b=i13smERRoqIIUARzcnZCsZjXjWyC7xA40eqEloJrnhq2qqXyriLWuxedxguzKTtB2zCh1c XW6qCaDCa4r44JqRYQAQfFJ+e14mdXCSyEoXsbMz2QJH4DIJArSXJNi2/wBsNtWZGdwKss 9N8EJVBTQrzxJuV9GT+t4FIuxNDZ9e0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-V1Sr6BHiOI64oEIdkGxxcg-1; Tue, 15 Jun 2021 10:03:41 -0400 X-MC-Unique: V1Sr6BHiOI64oEIdkGxxcg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E32AD101F7D0; Tue, 15 Jun 2021 14:03:32 +0000 (UTC) Received: from localhost (ovpn-113-156.ams2.redhat.com [10.36.113.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D721318B4B; Tue, 15 Jun 2021 14:03:28 +0000 (UTC) From: Cornelia Huck To: Christoph Hellwig , Greg Kroah-Hartman , Jason Gunthorpe , Alex Williamson , Kirti Wankhede Subject: Re: [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind In-Reply-To: <20210615133519.754763-5-hch@lst.de> Organization: Red Hat GmbH References: <20210615133519.754763-1-hch@lst.de> <20210615133519.754763-5-hch@lst.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 15 Jun 2021 16:03:27 +0200 Message-ID: <87zgvrw7gw.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Krowiak , Jason Herne , kvm@vger.kernel.org, Vasily Gorbik , Jonathan Corbet , David Airlie , linux-s390@vger.kernel.org, Heiko Carstens , linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, Halil Pasic , Christian Borntraeger , Rodrigo Vivi , "Rafael J. Wysocki" , intel-gfx@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 15 2021, Christoph Hellwig wrote: > EPROBE_DEFER is an internal kernel error code and it should not be leaked > to userspace via the bind_store() sysfs. Userspace doesn't have this > constant and cannot understand it. > > Further, it doesn't really make sense to have userspace trigger a deferred > probe via bind_store(), which could eventually succeed, while > simultaneously returning an error back. > > Resolve this by splitting driver_probe_device so that the version used > by the sysfs binding that turns EPROBE_DEFER into -EAGAIN, while the one > used for internally binding keeps the error code, and calls > driver_deferred_probe_add where needed. This also allows to nicely split > out the defer_all_probes / probe_count checks so that they actually allow > for full device_{block,unblock}_probing protection while not bothering > the sysfs bind case. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Greg Kroah-Hartman > --- > drivers/base/dd.c | 78 +++++++++++++++++++++++++---------------------- > 1 file changed, 42 insertions(+), 36 deletions(-) > Reviewed-by: Cornelia Huck