From: Ashwin H <ashwinh@vmware.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
Steven Rostedt <srostedt@vmware.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"stable@kernel.org" <stable@kernel.org>,
Srivatsa Bhat <srivatsab@vmware.com>
Subject: Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'
Date: Wed, 13 May 2020 06:13:17 +0000 [thread overview]
Message-ID: <89DE19F6-4CB0-4324-A630-C8574C8D591C@vmware.com> (raw)
In-Reply-To: <20200513055548.GA743118@kroah.com>
This patch fixes CVE-2018-20669 in 4.19 tree.
On 13/05/20, 11:36 AM, "Greg KH" <gregkh@linuxfoundation.org> wrote:
On Wed, May 13, 2020 at 07:19:21AM +0530, ashwin-h wrote:
> From: Linus Torvalds <torvalds@linux-foundation.org>
>
> commit 594cc251fdd0d231d342d88b2fdff4bc42fb0690 upstream.
>
> Originally, the rule used to be that you'd have to do access_ok()
> separately, and then user_access_begin() before actually doing the
> direct (optimized) user access.
>
> But experience has shown that people then decide not to do access_ok()
> at all, and instead rely on it being implied by other operations or
> similar. Which makes it very hard to verify that the access has
> actually been range-checked.
>
> If you use the unsafe direct user accesses, hardware features (either
> SMAP - Supervisor Mode Access Protection - on x86, or PAN - Privileged
> Access Never - on ARM) do force you to use user_access_begin(). But
> nothing really forces the range check.
>
> By putting the range check into user_access_begin(), we actually force
> people to do the right thing (tm), and the range check vill be visible
> near the actual accesses. We have way too long a history of people
> trying to avoid them.
>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Ashwin H <ashwinh@vmware.com>
> ---
> arch/x86/include/asm/uaccess.h | 11 ++++++++++-
> drivers/gpu/drm/i915/i915_gem_execbuffer.c | 15 +++++++++++++--
> include/linux/uaccess.h | 2 +-
> kernel/compat.c | 6 ++----
> kernel/exit.c | 6 ++----
> lib/strncpy_from_user.c | 9 +++++----
> lib/strnlen_user.c | 9 +++++----
> 7 files changed, 38 insertions(+), 20 deletions(-)
Are you wanting this merged to a specific stable kernel tree? If so, why?
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-13 6:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 1:49 [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()' ashwin-h
2020-05-13 5:55 ` Greg KH
2020-05-13 6:13 ` Ashwin H [this message]
2020-05-13 6:34 ` Greg KH
2020-05-13 17:08 ` Ashwin H
2020-05-27 15:31 ` Greg KH
2020-05-28 7:30 ` Ashwin H
2020-05-28 11:20 ` Ashwin H
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89DE19F6-4CB0-4324-A630-C8574C8D591C@vmware.com \
--to=ashwinh@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=srivatsa@csail.mit.edu \
--cc=srivatsab@vmware.com \
--cc=srostedt@vmware.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).