From: Thomas Zimmermann <tzimmermann@suse.de>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names
Date: Wed, 26 May 2021 21:24:12 +0200 [thread overview]
Message-ID: <89bec7e1-135a-71b6-8d87-ebca19443d3d@suse.de> (raw)
In-Reply-To: <20210525151313.3379622-1-javierm@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 2042 bytes --]
Am 25.05.21 um 17:13 schrieb Javier Martinez Canillas:
> Framebuffer devices that are registered by DRM drivers for fbdev emulation
> have a "drmfb" suffix in their name. But makes them to be quite confusing
> for drivers that already have "drm" in their name:
>
> $ cat /proc/fb
> 0 rockchipdrmdrmfb
>
> $ cat /proc/fb
> 0 simpledrmdrmfb
>
> Also, there isn't a lot of value in adding these "drmfb" suffices to their
> names, since users shouldn't really care if the FB devices were registered
> by a real fbdev driver or a DRM driver using the fbdev emulation.
>
> What programs should be interested about is if there's a DRM device, and
> there are better ways to query that info than reading this procfs entry.
>
> So let's just remove the suffix, which leads to much better device names:
>
> $ cat /proc/fb
> 0 rockchipdrm
>
> $ cat /proc/fb
> 0 simpledrm
>
> Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Added to drm-misc-next. Thank you.
Best regards
Thomas
> ---
>
> Changes in v2:
> - Just remove the "drmfb" suffix instead of using a different one (tzimmermann).
>
> drivers/gpu/drm/drm_fb_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index f6baa204612..d77a24507d3 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -1737,7 +1737,7 @@ void drm_fb_helper_fill_info(struct fb_info *info,
> sizes->fb_width, sizes->fb_height);
>
> info->par = fb_helper;
> - snprintf(info->fix.id, sizeof(info->fix.id), "%sdrmfb",
> + snprintf(info->fix.id, sizeof(info->fix.id), "%s",
> fb_helper->dev->driver->name);
>
> }
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
prev parent reply other threads:[~2021-05-26 19:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 15:13 [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names Javier Martinez Canillas
2021-05-26 7:20 ` Thomas Zimmermann
2021-05-26 19:24 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89bec7e1-135a-71b6-8d87-ebca19443d3d@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).