From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA71C2BA2B for ; Thu, 16 Apr 2020 07:00:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E749206A2 for ; Thu, 16 Apr 2020 07:00:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="eQBdLl06" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E749206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 896446EAEA; Thu, 16 Apr 2020 06:59:30 +0000 (UTC) Received: from mo6-p02-ob.smtp.rzone.de (mo6-p02-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5302::10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F24A6E7D2 for ; Wed, 15 Apr 2020 14:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1586959644; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=3xRYp708JzBcF+nmyzTN9euUKBZizEPeF9myzhSW4qw=; b=eQBdLl06shmnSjGR62mlDQtz+OvVjYWgUXtO8tq0YihaJiW2vsbk18M7NKH/neCpPd VUfK88NJAA3az3jLxMhi2hPFX5O9thtGNQpEiTjueSbMZIEiMaFdkFW6zF/kcYl59NSc mueNktsp80nF6XRrTEhSJC7zcToQKIUa6U6pCjDhtEUgyG0YW/ZsNIdHhwhyLaPcjahE tGQXiGBcft0yUDCZRlD/FC2PD5u6yCpcbM+SsFL5d2OxGam+EHy1IE57dEP6X+7CWLxI 1RgZSGdsvSRrGEpxuyEtK3YXhwcQ3lv/pijpXLk8npd797uS9NC/a3NfKuvNuUvJXQEQ IgDA== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBp5hRw/qOxWRk4dCz3b9m9rH79DVQJPCq5egpDhipvc+uRd0DTkACO" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2001:16b8:26b3:fd00:65ed:197b:42b7:ade5] by smtp.strato.de (RZmta 46.4.0 AUTH) with ESMTPSA id 6028a2w3FE7B2MX (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 15 Apr 2020 16:07:11 +0200 (CEST) Subject: Re: [PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: "H. Nikolaus Schaller" In-Reply-To: <20200415134754.GB21120@kozik-lap> Date: Wed, 15 Apr 2020 16:07:17 +0200 Message-Id: <8CC38F9F-885E-4EB9-9D36-1FFC6A86A45F@goldelico.com> References: <004611c9660943759b635a87484932869927cf74.1586939718.git.hns@goldelico.com> <20200415134754.GB21120@kozik-lap> To: Krzysztof Kozlowski X-Mailer: Apple Mail (2.3124) X-Mailman-Approved-At: Thu, 16 Apr 2020 06:59:07 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt_Cousson?= , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Am 15.04.2020 um 15:47 schrieb Krzysztof Kozlowski : > > On Wed, Apr 15, 2020 at 01:46:06PM +0200, H. Nikolaus Schaller wrote: >> Hi Krzysztof, >> >>> Am 15.04.2020 um 13:38 schrieb Krzysztof Kozlowski : >>> >>> On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: >>>> >>>> and add interrupt. >>>> >>>> Tested-by: H. Nikolaus Schaller # Pyra-Handheld. >>> >>> Don't add your own Tested-by tags. These are implied by authorship, >>> otherwise all patches people make should have such tag. >> >> Ok I see. AFAIR it originates in several phases of editing to report on which device it was tested. >> >> Is there a canonical way of writing "tested-on: ${HARDWARE}"? >> >> E.g. would this be ok? >> >> Signed-off: H. Nikolaus Schaller # tested on Pyra-Handheld > > If you think tested platform is worth mentioning in the commit msg > (it will stay there forever, ever, ever) then just add a line like: > > "Add SGX GPU node. Tested on Pyra-Handheld." > > From time to time we add such information to note that only one platform > was actually tested. Yes that is what it should express. > I am not sure what benefit it brings to most > cases... but your commit msg is so short that adding one more sentence > seems reasonable. :) Ok, will queue for v7. > > Best regards, > Krzysztof BR and thanks, Nikolaus _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel