From: Thomas Zimmermann <tzimmermann@suse.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Javier Martinez Canillas <javierm@redhat.com>
Subject: Re: [PATCH] drm/fb-helper: Fix missing kerneldoc include
Date: Tue, 8 Nov 2022 16:14:16 +0100 [thread overview]
Message-ID: <8d3c73b8-98ed-60fe-3b5a-ce17a4691561@suse.de> (raw)
In-Reply-To: <20221107190928.1212116-1-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 1902 bytes --]
Thanks. Merged with fixes for the following warnings.
66ba1150c07e (HEAD -> drm-misc-next) drm/fb-helper: Fix missing
kerneldoc include
-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style
'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8ab59da26bc0
("drm/fb-helper: Move generic fbdev emulation into separate source file")'
#6:
This was lost in the code movement done in 8ab59da26bc0
-:30: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address
mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' !=
'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>'
Best regards
Thomas
Am 07.11.22 um 20:09 schrieb Daniel Vetter:
> This was lost in the code movement done in 8ab59da26bc0
> ("drm/fb-helper: Move generic fbdev emulation into separate source
> file").
>
> Fixes: 8ab59da26bc0 ("drm/fb-helper: Move generic fbdev emulation into separate source file")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/drm-kms-helpers.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms-helpers.rst
> index dbc85fd7a971..a4860ffd6e86 100644
> --- a/Documentation/gpu/drm-kms-helpers.rst
> +++ b/Documentation/gpu/drm-kms-helpers.rst
> @@ -116,6 +116,9 @@ fbdev Helper Functions Reference
> .. kernel-doc:: drivers/gpu/drm/drm_fb_helper.c
> :export:
>
> +.. kernel-doc:: drivers/gpu/drm/drm_fbdev_generic.c
> + :export:
> +
> format Helper Functions Reference
> =================================
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
prev parent reply other threads:[~2022-11-08 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 19:09 [PATCH] drm/fb-helper: Fix missing kerneldoc include Daniel Vetter
2022-11-08 11:49 ` Thomas Zimmermann
2022-11-08 15:14 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d3c73b8-98ed-60fe-3b5a-ce17a4691561@suse.de \
--to=tzimmermann@suse.de \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).