From: David Laight <David.Laight@ACULAB.COM>
To: 'Christoph Hellwig' <hch@lst.de>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Petr Mladek <pmladek@suse.com>,
Michal Marek <michal.lkml@markovi.net>,
Andrew Donnellan <ajd@linux.ibm.com>,
Jessica Yu <jeyu@kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
Masahiro Yamada <masahiroy@kernel.org>,
Jiri Kosina <jikos@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joe Lawrence <joe.lawrence@redhat.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Frederic Barrat <fbarrat@linux.ibm.com>,
"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: [PATCH 02/13] module: add a module_loaded helper
Date: Thu, 21 Jan 2021 17:44:55 +0000 [thread overview]
Message-ID: <8d59f11971764db2a104c87937e1d3ab@AcuMS.aculab.com> (raw)
In-Reply-To: <20210121171119.GA29916@lst.de>
>
> On Thu, Jan 21, 2021 at 11:00:20AM +0100, Christophe Leroy wrote:
> > > +bool module_loaded(const char *name);
> >
> > Maybe module_is_loaded() would be a better name.
>
> Fine with me.
It does look like both callers aren't 'unsafe'.
But it is a bit strange returning a stale value.
It did make be look a bit more deeply at try_module_get().
For THIS_MODULE (eg to get an extra reference for a kthread)
I doubt it can ever fail.
But the other cases require a 'module' structure be passed in.
ISTM that unloading the module could invalidate the pointer
that has just been read from some other structure.
I'm guessing that some other lock must always be held.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-22 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210121074959.313333-1-hch@lst.de>
[not found] ` <20210121074959.313333-9-hch@lst.de>
2021-01-21 8:25 ` [PATCH 08/13] drm: remove drm_fb_helper_modinit Daniel Vetter
[not found] ` <20210121082820.GA25719@lst.de>
2021-01-21 8:39 ` Daniel Vetter
[not found] ` <20210121074959.313333-2-hch@lst.de>
2021-01-21 9:09 ` [PATCH 01/13] powerpc/powernv: remove get_cxl_module Andrew Donnellan
[not found] ` <20210121074959.313333-3-hch@lst.de>
2021-01-21 10:00 ` [PATCH 02/13] module: add a module_loaded helper Christophe Leroy
[not found] ` <20210121171119.GA29916@lst.de>
2021-01-21 17:44 ` David Laight [this message]
[not found] ` <20210121074959.313333-5-hch@lst.de>
2021-01-21 21:45 ` [PATCH 04/13] livepatch: move klp_find_object_module to module.c Josh Poimboeuf
2021-01-26 14:25 ` Jessica Yu
2021-01-27 11:55 ` Petr Mladek
[not found] ` <20210121074959.313333-4-hch@lst.de>
2021-01-27 12:58 ` [PATCH 03/13] livepatch: refactor klp_init_object Petr Mladek
[not found] ` <20210121074959.313333-14-hch@lst.de>
2021-01-27 13:49 ` [PATCH 13/13] module: remove EXPORY_UNUSED_SYMBOL* Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d59f11971764db2a104c87937e1d3ab@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=airlied@linux.ie \
--cc=ajd@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dri-devel@lists.freedesktop.org \
--cc=fbarrat@linux.ibm.com \
--cc=hch@lst.de \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=michal.lkml@markovi.net \
--cc=pmladek@suse.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).