From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44B1EC433FE for ; Sat, 15 Oct 2022 21:37:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E2DA10E583; Sat, 15 Oct 2022 21:37:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7987710E585 for ; Sat, 15 Oct 2022 21:37:13 +0000 (UTC) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id BA69084C60; Sat, 15 Oct 2022 23:37:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1665869832; bh=uRbP9Pbodg+ge1e9KjYY/y4+n4ffCzR8RDLeg56nY7I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WRgNp22zaL9hseJbLU8PNwQDlqTwV7UBy3YEi1v94gh2I1mGcaq2VLY/1g+4553Ze VtouUnVtCFAjcrHY2WlEjchZ98ffPDUDhzNaH6QqFFZN9JOtBDnBhUrIac7qtME2KJ 3KPWxCZSoukXTxk8fwIY/pqyPt+9hshjJJCwWsL1XwgRNuSKSboTPuyQoOQmIWP6pL Q/L04k6ZCjQUOC3ttidCApAO2G/IPn25bSNMB8xBZZjSWE87SNeil9fX1wNTHdv+Cq KBLY2qKQPDWvc3YAYVmiGPmrfQCE+fw0VdCIKqQ3JDYnGVKJxJBPWHveVQz6pys2yz dvdb9e5B8bn2Q== Message-ID: <90ab7268-ca93-0598-e09b-258030654545@denx.de> Date: Sat, 15 Oct 2022 23:37:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v7 08/10] drm: bridge: samsung-dsim: Add input_bus_flags Content-Language: en-US To: Jagan Teki , Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai References: <20221005151309.7278-1-jagan@amarulasolutions.com> <20221005151309.7278-9-jagan@amarulasolutions.com> From: Marek Vasut In-Reply-To: <20221005151309.7278-9-jagan@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Matteo Lisi , dri-devel@lists.freedesktop.org, NXP Linux Team , linux-amarula , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10/5/22 17:13, Jagan Teki wrote: [...] > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c > index f714e49c1eab..f5cd80641cea 100644 > --- a/drivers/gpu/drm/bridge/samsung-dsim.c > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c > @@ -1601,6 +1601,10 @@ static const struct samsung_dsim_host_ops samsung_dsim_generic_host_ops = { > .unregister_host = samsung_dsim_unregister_host, > }; > > +static const struct drm_bridge_timings samsung_dsim_bridge_timings = { > + .input_bus_flags = DRM_BUS_FLAG_DE_LOW, > +}; > + > int samsung_dsim_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -1681,6 +1685,7 @@ int samsung_dsim_probe(struct platform_device *pdev) > > dsi->bridge.funcs = &samsung_dsim_bridge_funcs; > dsi->bridge.of_node = dev->of_node; > + dsi->bridge.timings = &samsung_dsim_bridge_timings; Is this really valid on Exynos too ? My impression is that the DE_LOW requirement is only needed for MX8MM/MN where the LCDIF-DSIM glue logic inverts the HS/VS/DE signals, while on all other platforms (at least MX8MP) the inversion does not take place, so DE is really active HIGH there.