From: Dmitry Osipenko <digetx@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>,
andy.shevchenko@gmail.com, christian.koenig@amd.com,
dri-devel@lists.freedesktop.org, jonathanh@nvidia.com,
ldewangan@nvidia.com, linaro-mm-sig@lists.linaro.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
p.zabel@pengutronix.de, sumit.semwal@linaro.org,
thierry.reding@gmail.com, robh+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: tegra: Add SMBus block read and SMBus alert functions
Date: Thu, 9 Dec 2021 18:43:51 +0300 [thread overview]
Message-ID: <9443afa6-b668-ae31-2413-05aa95a9567d@gmail.com> (raw)
In-Reply-To: <1639062321-18840-3-git-send-email-akhilrajeev@nvidia.com>
09.12.2021 18:05, Akhil R пишет:
> +static int tegra_i2c_setup_smbalert(struct tegra_i2c_dev *i2c_dev)
> +{
> + struct tegra_i2c_smbalert *smbalert = &i2c_dev->smbalert;
> + struct gpio_desc *alert_gpiod;
> + struct i2c_client *ara;
> +
> + alert_gpiod = devm_gpiod_get(i2c_dev->dev, "smbalert", GPIOD_IN);
> + if (IS_ERR(alert_gpiod))
> + return PTR_ERR(alert_gpiod);
> +
> + smbalert->alert_data.irq = gpiod_to_irq(alert_gpiod);
> + if (smbalert->alert_data.irq <= 0)
> + return smbalert->alert_data.irq;
Why GPIO is needed at all if what's actually needed is the interrupt?
next prev parent reply other threads:[~2021-12-09 17:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 15:05 [PATCH 0/2] Add SMBus features to Tegra I2C Akhil R
2021-12-09 15:05 ` [PATCH 1/2] dt-bindings: i2c: tegra: Add SMBus feature properties Akhil R
2021-12-09 15:30 ` Andy Shevchenko
2021-12-15 18:37 ` Rob Herring
2021-12-09 15:05 ` [PATCH 2/2] i2c: tegra: Add SMBus block read and SMBus alert functions Akhil R
2021-12-09 15:27 ` Dmitry Osipenko
2021-12-09 15:30 ` Dmitry Osipenko
2021-12-09 15:33 ` Andy Shevchenko
2021-12-09 15:42 ` Dmitry Osipenko
2021-12-09 15:43 ` Dmitry Osipenko [this message]
2021-12-09 16:04 ` [PATCH 0/2] Add SMBus features to Tegra I2C Dmitry Osipenko
2021-12-10 8:56 ` Thierry Reding
2021-12-15 18:42 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9443afa6-b668-ae31-2413-05aa95a9567d@gmail.com \
--to=digetx@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=christian.koenig@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).