From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8230C282DD for ; Thu, 9 Jan 2020 17:52:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4381F20678 for ; Thu, 9 Jan 2020 17:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=daemonic.se header.i=@daemonic.se header.b="K05cTLzc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4381F20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=daemonic.se Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB9E86E93D; Thu, 9 Jan 2020 17:51:31 +0000 (UTC) X-Greylist: delayed 583 seconds by postgrey-1.36 at gabe; Thu, 09 Jan 2020 15:38:07 UTC Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 84CF46E43F for ; Thu, 9 Jan 2020 15:38:07 +0000 (UTC) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 47tqkr4r63z3l8s; Thu, 9 Jan 2020 15:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=daemonic.se; h= content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:subject:subject:received :received; s=20151023; t=1578583699; bh=+Bq/Skzh2brYvuUEgK16FFW2 urEOuah5bGs2NUrosZw=; b=K05cTLzc46M+4xGEeM4SjJH4GaVh0GEL7EoV+Anc rSJP7UvETWNQDgZpkUpSKIREwJJBHoxDki8/LYl5xcbal3nBbMPLAKZvZP7uMxiO bwX21Yh5ctB3B4Jmgp1Z3Ar8apqRLO6tX7Yk2ToTLt7j1AvN16Bunf4fW16G3V7i 7/8= X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id wWjF_7u8LyI5; Thu, 9 Jan 2020 15:28:19 +0000 (UTC) Received: from garnet.daemonic.se (unknown [95.202.48.196]) by mail.daemonic.se (Postfix) with ESMTPSA id 47tqkp56ktz3l8C; Thu, 9 Jan 2020 15:28:18 +0000 (UTC) Subject: Re: [PATCH] xf86drm: only include for FreeBSD build case To: Jani Nikula , Seung-Woo Kim , dri-devel@lists.freedesktop.org References: <1578562330-25594-1-git-send-email-sw0312.kim@samsung.com> <871rs8psjy.fsf@intel.com> From: Niclas Zeising Message-ID: <94d436b2-b4e0-3414-a2fc-9d58e5ad4c07@daemonic.se> Date: Thu, 9 Jan 2020 16:28:17 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <871rs8psjy.fsf@intel.com> Content-Language: en-US X-Mailman-Approved-At: Thu, 09 Jan 2020 17:51:28 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eric.engestrom@intel.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-01-09 16:18, Jani Nikula wrote: > On Thu, 09 Jan 2020, Seung-Woo Kim wrote: >> The header is only required FreeBSD and GNU libc >> 2.30 starts to warn about Linux specific header >> deprecation. Only include for FreeBSD. >> >> Signed-off-by: Seung-Woo Kim >> --- >> xf86drmMode.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/xf86drmMode.c b/xf86drmMode.c >> index 207d7be..ff1d31d 100644 >> --- a/xf86drmMode.c >> +++ b/xf86drmMode.c >> @@ -42,9 +42,11 @@ >> #include >> #include >> #include >> +#if defined (__FreeBSD__) || defined (__FreeBSD_kernel__) >> #ifdef HAVE_SYS_SYSCTL_H > > Not that I know anything about this, but shouldn't you instead fix > HAVE_SYS_SYSCTL_H definition in configure stage to only be enabled on > FreeBSD? > > BR, > Jani. > >> #include >> #endif >> +#endif /* defined (__FreeBSD__) || defined (__FreeBSD_kernel__) */ >> #include >> #include > Hi! This fix looks OK on FreeBSD (I haven't had time to test), however, as has been pointed out, perhaps the change should go into the meson build script or configure instead. I don't know if other OSes (other BSDs primarily) need this as well. I'm pretty sure it's needed on DragonflyBSD at least. Perhaps keep the include for everything except Linux for the time being? Regards -- Niclas Zeising _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel