[PATCH -next] backlight: pwm_bl: Switch to use dev_err_probe() helper

[PATCH -next] backlight: pwm_bl: Switch to use dev_err_probe() helper

[Yang Yingliang]

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
---
 drivers/video/backlight/pwm_bl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index c0523a0269ee..ae858e3bd38f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -513,9 +513,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 	}
 
 	if (IS_ERR(pb->pwm)) {
-		ret = PTR_ERR(pb->pwm);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "unable to request PWM\n");
+		ret = dev_err_probe(&pdev->dev, PTR_ERR(pb->pwm),
+				    "unable to request PWM\n");
 		goto err_alloc;
 	}
 
-- 
2.25.1

Re: [PATCH -next] backlight: pwm_bl: Switch to use dev_err_probe() helper

[Daniel Thompson]

On Mon, Sep 26, 2022 at 09:32:58PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.

I'd prefer to have received these patches as a patchset rather than
individual patches... but it is a good change so:

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.

Re: [PATCH -next] backlight: pwm_bl: Switch to use dev_err_probe() helper

[Daniel Thompson]

On Mon, Sep 26, 2022 at 02:37:50PM +0100, Daniel Thompson wrote:
> On Mon, Sep 26, 2022 at 09:32:58PM +0800, Yang Yingliang wrote:
> > In the probe path, dev_err() can be replaced with dev_err_probe()
> > which will check if error code is -EPROBE_DEFER and prints the
> > error name. It also sets the defer probe reason which can be
> > checked later through debugfs. It's more simple in error path.
>
> I'd prefer to have received these patches as a patchset rather than
> individual patches... but it is a good change so:
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

Oops. My last mail neglected to mention that you did not sign off your
changes (meaning we cannot accept them). When you re-send this please
add a SoB and combine with the other similar patches.


Daniel.

Re: [PATCH -next] backlight: pwm_bl: Switch to use dev_err_probe() helper

[Yang Yingliang]

Hi,

On 2022/9/26 21:41, Daniel Thompson wrote:
> On Mon, Sep 26, 2022 at 02:37:50PM +0100, Daniel Thompson wrote:
>> On Mon, Sep 26, 2022 at 09:32:58PM +0800, Yang Yingliang wrote:
>>> In the probe path, dev_err() can be replaced with dev_err_probe()
>>> which will check if error code is -EPROBE_DEFER and prints the
>>> error name. It also sets the defer probe reason which can be
>>> checked later through debugfs. It's more simple in error path.
>> I'd prefer to have received these patches as a patchset rather than
>> individual patches... but it is a good change so:
>>
>> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Oops. My last mail neglected to mention that you did not sign off your
> changes (meaning we cannot accept them). When you re-send this please
> add a SoB and combine with the other similar patches.
I missed -s when doing format-patch, I will add my SoB and your reivew 
tag in v2.

Thanks,
Yang
>
>
> Daniel.
> .