Re: [PATCH v4 04/14] drm/sched: Cancel and flush all oustatdning jobs before finish.

From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	daniel.vetter@ffwll.ch, robh@kernel.org, l.stach@pengutronix.de,
	yuq825@gmail.com, eric@anholt.net
Cc: Alexander.Deucher@amd.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH v4 04/14] drm/sched: Cancel and flush all oustatdning jobs before finish.
Date: Tue, 19 Jan 2021 10:50:49 +0100	[thread overview]
Message-ID: <98192b24-47fe-3b02-97e2-5f33495814fb@gmail.com> (raw)
In-Reply-To: <667cef85-a7e9-fba5-132a-5fb57d7e8b62@gmail.com>

Added a CC: stable tag and pushed it.

Thanks,
Christian.

Am 19.01.21 um 09:42 schrieb Christian König:
> This is a bug fix and should probably be pushed separately to 
> drm-misc-next.
>
> Christian.
>
> Am 18.01.21 um 22:01 schrieb Andrey Grodzovsky:
>> To avoid any possible use after free.
>>
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
>> ---
>>   drivers/gpu/drm/scheduler/sched_main.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/scheduler/sched_main.c 
>> b/drivers/gpu/drm/scheduler/sched_main.c
>> index 997aa15..92637b7 100644
>> --- a/drivers/gpu/drm/scheduler/sched_main.c
>> +++ b/drivers/gpu/drm/scheduler/sched_main.c
>> @@ -899,6 +899,9 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched)
>>       if (sched->thread)
>>           kthread_stop(sched->thread);
>>   +    /* Confirm no work left behind accessing device structures */
>> +    cancel_delayed_work_sync(&sched->work_tdr);
>> +
>>       sched->ready = false;
>>   }
>>   EXPORT_SYMBOL(drm_sched_fini);
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel