From: Joe Perches <joe@perches.com>
To: Alastair D'Silva <alastair@au1.ibm.com>, alastair@d-silva.org
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Dan Carpenter <dan.carpenter@oracle.com>,
Karsten Keil <isdn@linux-pingi.de>,
Jassi Brar <jassisinghbrar@gmail.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"David S. Miller" <davem@davemloft.net>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Kalle Valo <kvalo@codeaurora.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexa
Subject: Re: [PATCH v3 0/7] Hexdump Enhancements
Date: Wed, 19 Jun 2019 09:31:24 -0700 [thread overview]
Message-ID: <9a000734375c0801fc16b71f4be1235f9b857772.camel@perches.com> (raw)
In-Reply-To: <20190617020430.8708-1-alastair@au1.ibm.com>
On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote:
> From: Alastair D'Silva <alastair@d-silva.org>
>
> Apologies for the large CC list, it's a heads up for those responsible
> for subsystems where a prototype change in generic code causes a change
> in those subsystems.
>
> This series enhances hexdump.
Still not a fan of these patches.
> These improve the readability of the dumped data in certain situations
> (eg. wide terminals are available, many lines of empty bytes exist, etc).
Changing hexdump's last argument from bool to int is odd.
Perhaps a new function should be added instead of changing
the existing hexdump.
> The default behaviour of hexdump is unchanged, however, the prototype
> for hex_dump_to_buffer() has changed, and print_hex_dump() has been
> renamed to print_hex_dump_ext(), with a wrapper replacing it for
> compatibility with existing code, which would have been too invasive to
> change.
>
> Hexdump selftests have be run & confirmed passed.
next prev parent reply other threads:[~2019-06-19 16:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 2:04 [PATCH v3 0/7] Hexdump Enhancements Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 1/7] lib/hexdump.c: Fix selftests Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 2/7] lib/hexdump.c: Relax rowsize checks in hex_dump_to_buffer Alastair D'Silva
2019-06-17 22:47 ` Randy Dunlap
2019-06-18 0:57 ` Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes Alastair D'Silva
[not found] ` <20190617020430.8708-4-alastair-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org>
2019-06-17 4:07 ` Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags Alastair D'Silva
2019-06-17 7:39 ` Jani Nikula
2019-06-17 2:04 ` [PATCH v3 5/7] lib/hexdump.c: Allow multiple groups to be separated by lines '|' Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 6/7] lib/hexdump.c: Allow multiple groups to be separated by spaces Alastair D'Silva
2019-06-17 2:04 ` [PATCH v3 7/7] lib/hexdump.c: Optionally retain byte ordering Alastair D'Silva
2019-06-19 16:31 ` Joe Perches [this message]
2019-06-19 23:15 ` [PATCH v3 0/7] Hexdump Enhancements Alastair D'Silva
2019-06-20 0:35 ` Joe Perches
2019-06-20 1:14 ` Alastair D'Silva
2019-06-20 2:00 ` Joe Perches
2019-06-20 10:50 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a000734375c0801fc16b71f4be1235f9b857772.camel@perches.com \
--to=joe@perches.com \
--cc=Jose.Abreu@synopsys.com \
--cc=airlied@linux.ie \
--cc=alastair@au1.ibm.com \
--cc=alastair@d-silva.org \
--cc=bleung@chromium.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=isdn@linux-pingi.de \
--cc=jani.nikula@linux.intel.com \
--cc=jassisinghbrar@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kvalo@codeaurora.org \
--cc=martin.petersen@oracle.com \
--cc=rodrigo.vivi@intel.com \
--cc=sgruszka@redhat.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).