Re: Radeon NI: GIT kernel with the nislands_smc commit doesn't boot on a Freescale P5040 board and P.A.Semi Nemo board

From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Darren Stevens" <darren@stevens-zone.net>,
	"R.T.Dickinson" <rtd2@xtra.co.nz>,
	"Michel Dänzer" <michel@daenzer.net>,
	gustavoars@kernel.org,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"mad skateman" <madskateman@gmail.com>,
	alexander.deucher@amd.com,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"Christian Zigotzky" <info@xenosoft.de>
Subject: Re: Radeon NI: GIT kernel with the nislands_smc commit doesn't boot on a Freescale P5040 board and P.A.Semi Nemo board
Date: Sat, 8 May 2021 13:33:02 +0200	[thread overview]
Message-ID: <9bb5fcbd-daf5-1669-b3e7-b8624b3c36f9@xenosoft.de> (raw)
In-Reply-To: <10D1983F-33EF-46C3-976E-463D1CB5A6E9@xenosoft.de>

Hi Gustavo,

Your patch works! Thanks a lot! I tested it with my Freescale P5040 
board and P.A.Semi Nemo board with a connected AMD Radeon HD6970 NI 
graphics cards (Cayman
XT) today.

Have a nice day,
Christian

On 07 May 2021 at 08:43am, Christian Zigotzky wrote:
> Hi Gustavo,
>
> Great! I will test it. Many thanks for your help.
>
> Cheers,
> Christian
>
>
>> On 7. May 2021, at 01:55, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>>
>> Hi Christian,
>>
>>> On 4/30/21 06:59, Christian Zigotzky wrote:
>>> Hello,
>>>
>>> The Nemo board (A-EON AmigaOne X1000) [1] and the FSL P5040 Cyrus+ board (A-EON AmigaOne X5000) [2] with installed AMD Radeon HD6970 NI graphics cards (Cayman
>>> XT) [3] don't boot with the latest git kernel anymore after the commit "drm/radeon/nislands_smc.h: Replace one-element array with flexible-array member in
>>> struct NISLANDS_SMC_SWSTATE branch" [4].  This git kernel boots in a virtual e5500 QEMU machine with a VirtIO-GPU [5].
>>>
>>> I bisected today [6].
>>>
>>> Result: drm/radeon/nislands_smc.h: Replace one-element array with flexible-array member in struct NISLANDS_SMC_SWSTATE branch
>>> (434fb1e7444a2efc3a4ebd950c7f771ebfcffa31) [4] is the first bad commit.
>> I have a fix ready for this bug:
>> https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/commit/?h=testing/drm-nislands
>>
>> I wonder if you could help me to test it with your environment, please.
>> It should be applied on top of mainline.
>>
>> Thank you!
>> --
>> Gustavo
>>
>>> I was able to revert this commit [7] and after a new compiling, the kernel boots without any problems on my AmigaOnes.
>>>
>>> After that I created a patch for reverting this commit for new git test kernels. [3]
>>>
>>> The kernel compiles and boots with this patch on my AmigaOnes. Please find attached the kernel config files.
>>>
>>> Please check the first bad commit.
>>>
>>> Thanks,
>>> Christian
>>>
>>> [1] https://en.wikipedia.org/wiki/AmigaOne_X1000
>>> [2] http://wiki.amiga.org/index.php?title=X5000
>>> [3] https://forum.hyperion-entertainment.com/viewtopic.php?f=35&t=4377
>>> [4] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=434fb1e7444a2efc3a4ebd950c7f771ebfcffa31
>>> [5] qemu-system-ppc64 -M ppce500 -cpu e5500 -m 1024 -kernel uImage -drive format=raw,file=MintPPC32-X5000.img,index=0,if=virtio -netdev user,id=mynet0 -device
>>> virtio-net-pci,netdev=mynet0 -append "rw root=/dev/vda" -device virtio-vga -usb -device usb-ehci,id=ehci -device usb-tablet -device virtio-keyboard-pci -smp 4
>>> -vnc :1
>>> [6] https://forum.hyperion-entertainment.com/viewtopic.php?p=53074#p53074
>>> [7] git revert 434fb1e7444a2efc3a4ebd950c7f771ebfcffa3