From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: freedreno@lists.freedesktop.org,
Yassine Oudjana <y.oudjana@protonmail.com>,
David Airlie <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sean Paul <sean@poorly.run>
Subject: Re: [RFC PATCH] drm/msm: lookup the ICC paths in both mdp5/dpu and mdss devices
Date: Fri, 26 Aug 2022 12:16:40 +0300 [thread overview]
Message-ID: <9e040bdb-4fc5-3c95-fcea-b6ac7fd8224b@linaro.org> (raw)
In-Reply-To: <20220805122406.x7xxywofeaquhfxg@SoMainline.org>
On 05/08/2022 15:24, Marijn Suijten wrote:
> On 2022-08-05 14:56:30, Dmitry Baryshkov wrote:
>> The commit 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master
>> components") changed the MDP5 driver to look for the interconnect paths
>> in the MDSS device rather than in the MDP5 device itself. This was left
>> unnoticed since on my testing devices the interconnects probably didn't
>> reach the sync state.
>>
>> Rather than just using the MDP5 device for ICC path lookups for the MDP5
>> devices, introduce an additional helper to check both MDP5/DPU and MDSS
>> nodes. This will be helpful for the MDP5->DPU conversion, since the
>> driver will have to check both nodes.
>>
>> Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components")
>> Reported-by: Marijn Suijten <marijn.suijten@somainline.org>
>> Reported-by: Yassine Oudjana <y.oudjana@protonmail.com>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Tested-by: Marijn Suijten <marijn.suijten@somainline.org> # On sdm630
>
> But I'm not sure about giving my Reviewed-by to this, as I'd rather
> *correct* the DT bindings for sdm630 and msm8996 to provide
> interconnects in the MDSS node unless there are strong reasons not to
> (and I don't consider "backwards compatibility" to be one, this binding
> "never even existed" if mdp5.txt is to be believed).
As a kind of a joke, I'd prefer to have interconnects in the mdp/dpu
device node. In the end, the interconnects describe the path between the
display controller and the DDR, not the path between the whole MDSS and DDR.
So, for next chipsets I'd vote to move icc to dpu/mdp node (and maybe
even move existing inerconnects to the dpu node).
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-08-26 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 11:56 [RFC PATCH] drm/msm: lookup the ICC paths in both mdp5/dpu and mdss devices Dmitry Baryshkov
2022-08-05 12:24 ` Marijn Suijten
2022-08-26 9:16 ` Dmitry Baryshkov [this message]
2022-10-19 9:13 ` Marijn Suijten
2022-10-19 9:27 ` Dmitry Baryshkov
2022-08-05 13:14 ` Yassine Oudjana
2022-08-23 21:31 ` Stephen Boyd
2022-08-26 9:18 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e040bdb-4fc5-3c95-fcea-b6ac7fd8224b@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).